Supports increment as well as Increment

Author: flovilmart

spec/Parse.Push.spec.js

@@ -1,28 +1,32 @@
 'use strict';
-describe('Parse.Push', () => {
-  it('should properly send push', (done) => {
-      var pushAdapter = {
-        send: function(body, installations) {
-          var badge = body.data.badge;
-          let promises = installations.map((installation) => {
-            if (installation.deviceType == "ios") {
-              expect(installation.badge).toEqual(badge);
-              expect(installation.originalBadge+1).toEqual(installation.badge);
-            } else {
-              expect(installation.badge).toBeUndefined();
-            }
-            return Promise.resolve({
-              err: null,
-              deviceType: installation.deviceType,
-              result: true
-            })
-          });
-          return Promise.all(promises)
-        },
-        getValidPushTypes: function() {
-          return ["ios", "android"];
-        }
+
+
+var pushAdapter = {
+  send: function(body, installations) {
+    var badge = body.data.badge;
+    let promises = installations.map((installation) => {
+      if (installation.deviceType == "ios") {
+        expect(installation.badge).toEqual(badge);
+        expect(installation.originalBadge+1).toEqual(installation.badge);
+      } else {
+        expect(installation.badge).toBeUndefined();
       }
+      return Promise.resolve({
+        err: null,
+        deviceType: installation.deviceType,
+        result: true
+      })
+    });
+    return Promise.all(promises)
+  },
+  getValidPushTypes: function() {
+    return ["ios", "android"];
+  }
+}
+
+describe('Parse.Push', () => {
+
+  beforeEach((done) => {
     setServerConfiguration({
       appId: Parse.applicationId,
       masterKey: Parse.masterKey,
@@ -42,20 +46,44 @@ describe('Parse.Push', () => {
       installations.push(installation);
     }
     Parse.Object.saveAll(installations).then(() => {
-      return Parse.Push.send({
-        where: {
-          deviceType: 'ios'
-        },
-        data: {
-          badge: 'Increment',
-          alert: 'Hello world!'
-        }
-      }, {useMasterKey: true});
+      done();
     })
+  })
+
+  it('should properly send push', (done) => {
+    return Parse.Push.send({
+      where: {
+        deviceType: 'ios'
+      },
+      data: {
+        badge: 'Increment',
+        alert: 'Hello world!'
+      }
+    }, {useMasterKey: true})
+    .then(() => {
+      done();
+    }, (err) => {
+      console.error();
+      fail('should not fail sending push')
+      done();
+    });
+  });
+
+  it('should properly send push with lowercaseIncrement', (done) => {
+    return Parse.Push.send({
+      where: {
+        deviceType: 'ios'
+      },
+      data: {
+        badge: 'increment',
+        alert: 'Hello world!'
+      }
+    }, {useMasterKey: true})
     .then(() => {
       done();
     }, (err) => {
-      console.error(err);
+      console.error();
+      fail('should not fail sending push')
       done();
     });
   });

src/Controllers/PushController.js

@@ -56,11 +56,11 @@ export class PushController extends AdaptableController {
     if (body.data && body.data.badge) {
       let badge = body.data.badge;
       let op = {};
-      if (badge == "Increment") {
-        op = { $inc: { badge: 1 } }
-      } else if (Number(badge)) {
+      if (Number(badge)) {
         op = { $set: { badge: badge } }
-      } else {
+      } else if (String(badge) && badge.toLowerCase() === 'increment') {
+        op = { $inc: { badge: 1 } }
+      } else else {
         throw "Invalid value for badge, expected number or 'Increment'";
       }
       let updateWhere = deepcopy(where);