Skip to content

Commit 4f8e6df

Browse files
committed
Fix conflicting test
1 parent 762a279 commit 4f8e6df

File tree

2 files changed

+97
-37
lines changed

2 files changed

+97
-37
lines changed

spec/CloudCode.spec.js

+54
Original file line numberDiff line numberDiff line change
@@ -449,6 +449,60 @@ describe('Cloud Code', () => {
449449
expect(called).toBe(7);
450450
});
451451

452+
fit('afterFind should not be triggered when saving an object', async () => {
453+
let beforeSaves = 0;
454+
Parse.Cloud.beforeSave('SavingTest', () => {
455+
beforeSaves++;
456+
});
457+
458+
let afterSaves = 0;
459+
Parse.Cloud.afterSave('SavingTest', () => {
460+
afterSaves++;
461+
});
462+
463+
let beforeFinds = 0;
464+
Parse.Cloud.beforeFind('SavingTest', () => {
465+
beforeFinds++;
466+
});
467+
468+
let afterFinds = 0;
469+
Parse.Cloud.afterFind('SavingTest', () => {
470+
afterFinds++;
471+
});
472+
473+
const obj = new Parse.Object('SavingTest');
474+
obj.set('someField', 'some value 1');
475+
await obj.save();
476+
477+
expect(beforeSaves).toEqual(1);
478+
expect(afterSaves).toEqual(1);
479+
expect(beforeFinds).toEqual(0);
480+
expect(afterFinds).toEqual(0);
481+
482+
obj.set('someField', 'some value 2');
483+
await obj.save();
484+
485+
expect(beforeSaves).toEqual(2);
486+
expect(afterSaves).toEqual(2);
487+
expect(beforeFinds).toEqual(0);
488+
expect(afterFinds).toEqual(0);
489+
490+
await obj.fetch();
491+
492+
expect(beforeSaves).toEqual(2);
493+
expect(afterSaves).toEqual(2);
494+
expect(beforeFinds).toEqual(1);
495+
expect(afterFinds).toEqual(1);
496+
497+
obj.set('someField', 'some value 3');
498+
await obj.save();
499+
500+
expect(beforeSaves).toEqual(3);
501+
expect(afterSaves).toEqual(3);
502+
expect(beforeFinds).toEqual(1);
503+
expect(afterFinds).toEqual(1);
504+
});
505+
452506
it('test afterSave ran and created an object', function(done) {
453507
Parse.Cloud.afterSave('AfterSaveTest', function(req) {
454508
const obj = new Parse.Object('AfterSaveProof');

spec/ParseGraphQLServer.spec.js

+43-37
Original file line numberDiff line numberDiff line change
@@ -7634,22 +7634,25 @@ describe('ParseGraphQLServer', () => {
76347634
} = await apolloClient.mutate({
76357635
mutation: gql`
76367636
mutation Create($fields: CreateSomeClassFieldsInput) {
7637-
createSomeClass(fields: $fields) {
7638-
id
7639-
ACL {
7640-
users {
7641-
userId
7642-
read
7643-
write
7644-
}
7645-
roles {
7646-
roleName
7647-
read
7648-
write
7649-
}
7650-
public {
7651-
read
7652-
write
7637+
createSomeClass(input: { fields: $fields }) {
7638+
someClass {
7639+
id
7640+
objectId
7641+
ACL {
7642+
users {
7643+
userId
7644+
read
7645+
write
7646+
}
7647+
roles {
7648+
roleName
7649+
read
7650+
write
7651+
}
7652+
public {
7653+
read
7654+
write
7655+
}
76537656
}
76547657
}
76557658
}
@@ -7705,44 +7708,47 @@ describe('ParseGraphQLServer', () => {
77057708
public: { read: true, write: true, __typename: 'PublicACL' },
77067709
};
77077710
const query1 = new Parse.Query('SomeClass');
7708-
const obj1 = (await query1.get(createSomeClass.id, {
7711+
const obj1 = (await query1.get(createSomeClass.someClass.objectId, {
77097712
useMasterKey: true,
77107713
})).toJSON();
77117714
expect(obj1.ACL[user.id]).toEqual({ read: true, write: true });
77127715
expect(obj1.ACL[user2.id]).toEqual({ read: true });
77137716
expect(obj1.ACL['role:aRole']).toEqual({ read: true });
77147717
expect(obj1.ACL['role:aRole2']).toEqual({ write: true });
77157718
expect(obj1.ACL['*']).toEqual({ read: true, write: true });
7716-
expect(createSomeClass.ACL).toEqual(expectedCreateACL);
7719+
expect(createSomeClass.someClass.ACL).toEqual(expectedCreateACL);
77177720

77187721
const {
77197722
data: { updateSomeClass },
77207723
} = await apolloClient.mutate({
77217724
mutation: gql`
77227725
mutation Update($id: ID!, $fields: UpdateSomeClassFieldsInput) {
7723-
updateSomeClass(id: $id, fields: $fields) {
7724-
id
7725-
ACL {
7726-
users {
7727-
userId
7728-
read
7729-
write
7730-
}
7731-
roles {
7732-
roleName
7733-
read
7734-
write
7735-
}
7736-
public {
7737-
read
7738-
write
7726+
updateSomeClass(input: { id: $id, fields: $fields }) {
7727+
someClass {
7728+
id
7729+
objectId
7730+
ACL {
7731+
users {
7732+
userId
7733+
read
7734+
write
7735+
}
7736+
roles {
7737+
roleName
7738+
read
7739+
write
7740+
}
7741+
public {
7742+
read
7743+
write
7744+
}
77397745
}
77407746
}
77417747
}
77427748
}
77437749
`,
77447750
variables: {
7745-
id: createSomeClass.id,
7751+
id: createSomeClass.someClass.id,
77467752
fields: {
77477753
ACL: {
77487754
roles: [{ roleName: 'aRole', write: true, read: true }],
@@ -7767,14 +7773,14 @@ describe('ParseGraphQLServer', () => {
77677773
};
77687774

77697775
const query2 = new Parse.Query('SomeClass');
7770-
const obj2 = (await query2.get(createSomeClass.id, {
7776+
const obj2 = (await query2.get(createSomeClass.someClass.objectId, {
77717777
useMasterKey: true,
77727778
})).toJSON();
77737779

77747780
expect(obj2.ACL['role:aRole']).toEqual({ write: true, read: true });
77757781
expect(obj2.ACL[user.id]).toBeUndefined();
77767782
expect(obj2.ACL['*']).toEqual({ read: true });
7777-
expect(updateSomeClass.ACL).toEqual(expectedUpdateACL);
7783+
expect(updateSomeClass.someClass.ACL).toEqual(expectedUpdateACL);
77787784
});
77797785

77807786
it('should support pointer on create', async () => {

0 commit comments

Comments
 (0)