Skip to content

Commit 74ba811

Browse files
authored
Remove unused parameter in Cloud Function (#6969)
1 parent e6ac3b6 commit 74ba811

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

spec/CloudCode.spec.js

+4-6
Original file line numberDiff line numberDiff line change
@@ -1313,7 +1313,7 @@ describe('Cloud Code', () => {
13131313
object.set('before', 'save');
13141314
});
13151315

1316-
Parse.Cloud.define('removeme', (req, res) => {
1316+
Parse.Cloud.define('removeme', () => {
13171317
const testObject = new TestObject();
13181318
return testObject
13191319
.save()
@@ -1324,11 +1324,10 @@ describe('Cloud Code', () => {
13241324
.then(object => {
13251325
object.unset('remove');
13261326
return object.save();
1327-
})
1328-
.catch(res.error);
1327+
});
13291328
});
13301329

1331-
Parse.Cloud.define('removeme2', (req, res) => {
1330+
Parse.Cloud.define('removeme2', () => {
13321331
const testObject = new TestObject();
13331332
return testObject
13341333
.save()
@@ -1339,8 +1338,7 @@ describe('Cloud Code', () => {
13391338
.then(object => {
13401339
object.unset('remove');
13411340
return object.save();
1342-
})
1343-
.catch(res.error);
1341+
});
13441342
});
13451343

13461344
Parse.Cloud.run('removeme')

src/Routers/FunctionsRouter.js

+3-4
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export class FunctionsRouter extends PromiseRouter {
9696
});
9797
}
9898

99-
static createResponseObject(resolve, reject, message) {
99+
static createResponseObject(resolve, reject) {
100100
return {
101101
success: function (result) {
102102
resolve({
@@ -109,7 +109,6 @@ export class FunctionsRouter extends PromiseRouter {
109109
const error = triggers.resolveError(message);
110110
reject(error);
111111
},
112-
message: message,
113112
};
114113
}
115114
static handleCloudFunction(req) {
@@ -137,7 +136,7 @@ export class FunctionsRouter extends PromiseRouter {
137136
return new Promise(function (resolve, reject) {
138137
const userString = req.auth && req.auth.user ? req.auth.user.id : undefined;
139138
const cleanInput = logger.truncateLogMessage(JSON.stringify(params));
140-
const { success, error, message } = FunctionsRouter.createResponseObject(
139+
const { success, error } = FunctionsRouter.createResponseObject(
141140
result => {
142141
try {
143142
const cleanResult = logger.truncateLogMessage(JSON.stringify(result.response.result));
@@ -177,7 +176,7 @@ export class FunctionsRouter extends PromiseRouter {
177176
return triggers.maybeRunValidator(request, functionName);
178177
})
179178
.then(() => {
180-
return theFunction(request, { message });
179+
return theFunction(request);
181180
})
182181
.then(success, error);
183182
});

0 commit comments

Comments
 (0)