Skip to content

Commit ea33ef6

Browse files
committed
attempt to fix flaky test
1 parent b78edda commit ea33ef6

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

Diff for: spec/CloudCodeLogger.spec.js

+17-17
Original file line numberDiff line numberDiff line change
@@ -3,55 +3,55 @@ var LoggerController = require('../src/Controllers/LoggerController').LoggerCont
33
var FileLoggerAdapter = require('../src/Adapters/Logger/FileLoggerAdapter').FileLoggerAdapter;
44

55
describe("Cloud Code Logger", () => {
6-
it("should expose log to functions", (done) => {
6+
it("should expose log to trigger", (done) => {
77
var logController = new LoggerController(new FileLoggerAdapter());
88

9-
Parse.Cloud.define("loggerTest", (req, res) => {
10-
req.log.info('logTest', 'info log', {info: 'some log' });
11-
req.log.error('logTest','error log', {error: 'there was an error'});
9+
Parse.Cloud.beforeSave("MyObject", (req, res) => {
10+
req.log.info('beforeSave MyObject', 'info log', {info: 'some log' });
11+
req.log.error('beforeSave MyObject','error log', {error: 'there was an error'});
1212
res.success({});
1313
});
1414

15-
Parse.Cloud.run('loggerTest').then(() => {
16-
return logController.getLogs({from: Date.now() - 500, size: 1000});
15+
let obj = new Parse.Object('MyObject');
16+
obj.save().then(() => {
17+
return logController.getLogs({from: Date.now() - 500, size: 1000})
1718
}).then((res) => {
1819
expect(res.length).not.toBe(0);
1920
let lastLogs = res.slice(0, 2);
2021
let errorMessage = lastLogs[0];
2122
let infoMessage = lastLogs[1];
2223
expect(errorMessage.level).toBe('error');
2324
expect(errorMessage.error).toBe('there was an error');
24-
expect(errorMessage.message).toBe('logTest error log');
25+
expect(errorMessage.message).toBe('beforeSave MyObject error log');
2526
expect(infoMessage.level).toBe('info');
2627
expect(infoMessage.info).toBe('some log');
27-
expect(infoMessage.message).toBe('logTest info log');
28+
expect(infoMessage.message).toBe('beforeSave MyObject info log');
2829
done();
2930
});
3031
});
3132

32-
it("should expose log to trigger", (done) => {
33+
it("should expose log to functions", (done) => {
3334
var logController = new LoggerController(new FileLoggerAdapter());
3435

35-
Parse.Cloud.beforeSave("MyObject", (req, res) => {
36-
req.log.info('beforeSave MyObject', 'info log', {info: 'some log' });
37-
req.log.error('beforeSave MyObject','error log', {error: 'there was an error'});
36+
Parse.Cloud.define("loggerTest", (req, res) => {
37+
req.log.info('logTest', 'info log', {info: 'some log' });
38+
req.log.error('logTest','error log', {error: 'there was an error'});
3839
res.success({});
3940
});
4041

41-
let obj = new Parse.Object('MyObject');
42-
obj.save().then(() => {
43-
return logController.getLogs({from: Date.now() - 500, size: 1000})
42+
Parse.Cloud.run('loggerTest').then(() => {
43+
return logController.getLogs({from: Date.now() - 500, size: 1000});
4444
}).then((res) => {
4545
expect(res.length).not.toBe(0);
4646
let lastLogs = res.slice(0, 2);
4747
let errorMessage = lastLogs[0];
4848
let infoMessage = lastLogs[1];
4949
expect(errorMessage.level).toBe('error');
5050
expect(errorMessage.error).toBe('there was an error');
51-
expect(errorMessage.message).toBe('beforeSave MyObject error log');
51+
expect(errorMessage.message).toBe('logTest error log');
5252
expect(infoMessage.level).toBe('info');
5353
expect(infoMessage.info).toBe('some log');
54-
expect(infoMessage.message).toBe('beforeSave MyObject info log');
54+
expect(infoMessage.message).toBe('logTest info log');
5555
done();
5656
});
5757
});

0 commit comments

Comments
 (0)