Skip to content

this.ttl is always undefined on LRUCache.js #6475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yomybaby opened this issue Mar 7, 2020 · 1 comment
Closed

this.ttl is always undefined on LRUCache.js #6475

yomybaby opened this issue Mar 7, 2020 · 1 comment

Comments

@yomybaby
Copy link
Contributor

yomybaby commented Mar 7, 2020

Hi, I found some thing which is never used.

Please check the 16th line of LRUCache.js.

this.ttl is always undefined. it is never assigned. Even this is undefined, LRU use default TTL when put.(https://www.npmjs.com/package/lru-cache#api) So undefined doesn't make problems.

But this.ttl is never used. So it should be removed.
@stale
Copy link

stale bot commented Apr 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 23, 2020
@stale stale bot closed this as completed Apr 30, 2020
@parseplatformorg parseplatformorg mentioned this issue Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yomybaby