Skip to content

Fix: randomly failing tests #6758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mtrezza opened this issue Jun 26, 2020 · 7 comments
Closed

Fix: randomly failing tests #6758

mtrezza opened this issue Jun 26, 2020 · 7 comments
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@mtrezza
Copy link
Member

mtrezza commented Jun 26, 2020

Issue Description

Builds seem to be randomly failing in Travis CI. My assumption is that the cases have bugs rather than a general issue with the way tests are conducted because it seem to be always the same test cases that randomly fail at unrelated PRs. This leads to builds by bots to fail unnecessarily and kind of hinders the CI flow.

For example:

ParseGraphQLServer Auto API Schema Relay Spec Object Identification Id inputs should work either with global id or object id
Expected 'U2Vjb25kYXJ5T2JqZWN0OmhnSlNFTDhuS1o=' to be less than 'U2Vjb25kYXJ5T2JqZWN0Om5HUE9pa1NpZGQ='.

Observed in:

Expected Results

Tests should pass.

Actual Outcome

Tests randomly pass / fail at times.

@mtrezza
Copy link
Member Author

mtrezza commented Jun 26, 2020

@davimacedo Would you mind taking a look at it when you can? Maybe you can find the issue easily since you are familiar with the test case.

@mtrezza mtrezza changed the title Fix tests Fix randomly failing tests Jun 26, 2020
@mtrezza mtrezza changed the title Fix randomly failing tests Fix: randomly failing tests Jun 26, 2020
@dplewis
Copy link
Member

dplewis commented Jul 2, 2020

I agree @davimacedo is it ok if we xit for now? The the depbot and synx PRs are taking a while to close

@mtrezza
Copy link
Member Author

mtrezza commented Jul 7, 2020

I noticed that some 5 - 10 tests are randomly failing, maybe there is an additional other issue. My first guess would be something like a race condition, maybe indeed related to the test suite setup. Keeping an eye on it...

@davimacedo
Copy link
Member

Hi guys. Sorry for the delay. I will look at the failing tests (including the GraphQL ones) and send a PR.

@stale
Copy link

stale bot commented Aug 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 29, 2020
@mtrezza mtrezza added type:bug Impaired feature or lacking behavior that is likely assumed and removed discussion labels Sep 4, 2020
@stale
Copy link

stale bot commented Nov 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 8, 2020
@mtrezza mtrezza removed the stale label Nov 8, 2020
@mtrezza
Copy link
Member Author

mtrezza commented Nov 8, 2020

This issue seems to have been solved.

@mtrezza mtrezza closed this as completed Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

No branches or pull requests

3 participants