-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Apple sign in client_id typo #6858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for reporting. This may be an issue with the docs and therefore belong to the docs repository, however before we transfer this, I want to take a closer look at the Apple auth adapter. The test cases seem to use both parse-server/spec/AuthenticationAdapters.spec.js Line 1238 in 4cec333
parse-server/spec/AuthenticationAdapters.spec.js Line 1247 in 4cec333
@drdaz Since you worked on Sign-in with Apple on iOS recently, do you have any insight into the Apple auth adapter and why we have two different parameters in the test cases? |
I can't say that I do. But I took a look at the API history for the client config: https://developer.apple.com/documentation/sign_in_with_apple/clientconfigi?changes=latest_minor The clientId name appears to have been consistent across releases. |
@UnderratedDev As the committer, can you comment on this? |
I've been sniffing around the history for the Apple auth adapter, and it looks like we did use the client_id name internally in earlier revisions. Looks like we tried to stop doing that here 8e0e485. |
There isn't one particular reason to change from client_id to clientId. Mainly it was to be consistent with the rest of the code, for instance, we use keyId, verifyIdToken. Most of the code uses the camel case javascript style. We should be using just clientId. Those tests also need to be reworked as we don't have any parse credentials for apple. We have to input our own & generate our own tokens manually with a separate application. Also, side note, I made a pr for p8 file support for apple sign but it needs better testing (I don't wish to put in my p8 file or personal credentials). If anyone could help, that would be appreciated. #6648 Hope that clears it all up. |
I think there are some aspects to distinguish:
The authentication can be done in different ways:
It seems we are using neither directly, instead we use the JWT framework (which uses the Apple Web Service Endpoint) which has an parse-server/src/Adapters/Auth/apple.js Lines 71 to 75 in dd2b64e
My conclusion would be:
@drdaz, @UnderratedDev would you both agree to the conclusion? |
@mtrezza yep, I do remember using the Apple Sign in JS Framework & they do use clientId. Good catch! |
Yes... conclusion checks out. Nice. |
In documentation https://docs.parseplatform.org/parse-server/guide/#apple-authdata it is mentioning that you can use client_id. That might have been true in the past, but now the correct way is to use clientId.
The text was updated successfully, but these errors were encountered: