Skip to content

fix: LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server #9616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2025
Merged

fix: LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server #9616

merged 2 commits into from
Feb 24, 2025

Conversation

Chilldev
Copy link
Contributor

Pull Request

Issue

Closes: #9432

Approach

Add empty handlers to redis client error, connect, reconnecting, ready events.

@parse-github-assistant Parse GitHub Assistant
Copy link

Thanks for opening this pull request!

@Chilldev Chilldev changed the title Handle Redis createClient on error. fix: Redis 4 crash on disconnect. Feb 20, 2025
@mtrezza
Copy link
Member

mtrezza commented Feb 22, 2025

I guess you have seen it already - the CI fails for these tests:

1) RedisPubSub can create publisher
  - TypeError: Cannot read properties of undefined (reading 'on')

2) RedisPubSub can create subscriber
  - TypeError: Cannot read properties of undefined (reading 'on')

@mtrezza mtrezza mentioned this pull request Feb 22, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (ef68fb1) to head (5a507e7).
Report is 2 commits behind head on alpha.

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #9616   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         186      186           
  Lines       14816    14831   +15     
=======================================
+ Hits        13856    13871   +15     
  Misses        960      960

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title fix: Redis 4 crash on disconnect. fix: LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server Feb 23, 2025
mtrezza
mtrezza approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just to confirm, this is not a breaking change, right? For example, someone using Redis 3 can upgrade without any code changes.

@Chilldev
Copy link
Contributor Author

I borrowed the code from RedisCacheAdapter. So we should be fine.

@mtrezza mtrezza merged commit bbc6bd4 into parse-community:alpha Feb 24, 2025
24 checks passed
parseplatformorg pushed a commit that referenced this pull request Feb 24, 2025
@semantic-release-bot
chore(release): 8.0.0-alpha.12 [skip ci]
6a6bc2a 
# [8.0.0-alpha.12](8.0.0-alpha.11...8.0.0-alpha.12) (2025-02-24)

### Bug Fixes

* LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server ([#9616](#9616)) ([bbc6bd4](bbc6bd4))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.0.0-alpha.12

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Feb 24, 2025
parseplatformorg pushed a commit that referenced this pull request Mar 4, 2025
@semantic-release-bot
chore(release): 8.0.0 [skip ci]
3cb3c5f 
# [8.0.0](7.4.0...8.0.0) (2025-03-04)

### Bug Fixes

* LiveQueryServer crashes using cacheAdapter on disconnect from Redis 4 server ([#9616](#9616)) ([bbc6bd4](bbc6bd4))
* Push adapter not loading on some versions of Node 22 ([#9524](#9524)) ([ff7f671](ff7f671))
* Remove username from email verification and password reset process ([#8488](#8488)) ([d21dd97](d21dd97))
* Security upgrade node from 20.17.0-alpine3.20 to 20.18.2-alpine3.20 ([#9583](#9583)) ([8f85ae2](8f85ae2))

### Features

* Add dynamic master key by setting Parse Server option `masterKey` to a function ([#9582](#9582)) ([6f1d161](6f1d161))
* Add support for MongoDB `databaseOptions` keys `autoSelectFamily`, `autoSelectFamilyAttemptTimeout` ([#9579](#9579)) ([5966068](5966068))
* Add support for MongoDB `databaseOptions` keys `minPoolSize`, `connectTimeoutMS`, `socketTimeoutMS` ([#9522](#9522)) ([91618fe](91618fe))
* Add TypeScript support ([#9550](#9550)) ([59e46d0](59e46d0))
* Change default value of Parse Server option `encodeParseObjectInCloudFunction` to `true` ([#9527](#9527)) ([5c5ad69](5c5ad69))
* Deprecate `PublicAPIRouter` in favor of `PagesRouter` ([#9526](#9526)) ([7f66629](7f66629))
* Increase required minimum MongoDB versions to `6.0.19`, `7.0.16`, `8.0.4` ([#9531](#9531)) ([871e508](871e508))
* Increase required minimum Node versions to `18.20.4`, `20.18.0`, `22.12.0` ([#9521](#9521)) ([4e151cd](4e151cd))
* Increase required minimum versions to Postgres `15`, PostGIS `3.3` ([#9538](#9538)) ([89c9b54](89c9b54))
* Upgrade to express 5.0.1 ([#9530](#9530)) ([e0480df](e0480df))
* Upgrade to Parse JS SDK 6.0.0 ([#9624](#9624)) ([bf9db75](bf9db75))

### BREAKING CHANGES

* This upgrades the internally used Express framework from version 4 to 5, which may be a breaking change. If Parse Server is set up to be mounted on an Express application, we recommend to also use version 5 of the Express framework to avoid any compatibility issues. Note that even if there are no issues after upgrading, future releases of Parse Server may introduce issues if Parse Server internally relies on Express 5-specific features which are unsupported by the Express version on which it is mounted. See the Express [migration guide](https://expressjs.com/en/guide/migrating-5.html) and [release announcement](https://expressjs.com/2024/10/15/v5-release.html#breaking-changes) for more info. ([e0480df](e0480df))
* This upgrades to the Parse JS SDK 6.0.0. See the [change log](https://github.com/parse-community/Parse-SDK-JS/releases/tag/6.0.0) of the Parse JS SDK for breaking changes and more details. ([bf9db75](bf9db75))
* This removes the username from the email verification and password reset process to prevent storing personally identifiable information (PII) in server and infrastructure logs. Customized HTML pages or emails related to email verification and password reset may need to be adapted accordingly. See the new templates that come bundled with Parse Server and the [migration guide](https://github.com/parse-community/parse-server/blob/alpha/8.0.0.md) for more details. ([d21dd97](d21dd97))
* This releases increases the required minimum versions to Postgres `15`, PostGIS `3.3` and removes support for Postgres `13`, `14`, PostGIS `3.1`, `3.2`. ([89c9b54](89c9b54))
* The default value of Parse Server option `encodeParseObjectInCloudFunction` changes to `true`; the option has been deprecated and will be removed in a future version. ([5c5ad69](5c5ad69))
* This releases increases the required minimum MongoDB versions to `6.0.19`, `7.0.16`, `8.0.4` and removes support for MongoDB `4`, `5`. ([871e508](871e508))
* This releases increases the required minimum Node versions to 18.20.4, 20.18.0, 22.12.0 and removes unofficial support for Node 19. ([4e151cd](4e151cd))
@dplewis dplewis mentioned this pull request Mar 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released-alpha Released as alpha version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LiveQueryServer crashes when configured to run with Redis cacheAdapter
3 participants
@Chilldev @mtrezza @parseplatformorg