From d0728b4a0a693e2dd95ce01a13fc7b8437056238 Mon Sep 17 00:00:00 2001 From: youngerong Date: Tue, 9 May 2017 11:24:46 +0800 Subject: [PATCH 1/2] fix-3789 --- src/Controllers/LoggerController.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/Controllers/LoggerController.js b/src/Controllers/LoggerController.js index 5110526a44..c87f8f4642 100644 --- a/src/Controllers/LoggerController.js +++ b/src/Controllers/LoggerController.js @@ -64,6 +64,15 @@ export class LoggerController extends AdaptableController { } } + if (e.params) { + for (const key of Object.keys(e.params)) { + if (key === 'password') { + e.params[key] = '********'; + break; + } + } + } + return e; }); } From a76ecb9c70ef677ea981e1dc7a95ba764dce2617 Mon Sep 17 00:00:00 2001 From: youngerong Date: Thu, 11 May 2017 13:24:53 +0800 Subject: [PATCH 2/2] fix3789 add unit test --- spec/CloudCodeLogger.spec.js | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/spec/CloudCodeLogger.spec.js b/spec/CloudCodeLogger.spec.js index 54a4d1da5d..e4a57e3c83 100644 --- a/spec/CloudCodeLogger.spec.js +++ b/spec/CloudCodeLogger.spec.js @@ -228,3 +228,20 @@ describe("Cloud Code Logger", () => { .then(null, e => done.fail(JSON.stringify(e))); }).pend('needs more work.....'); }); + +it('cloud function should obfuscate password', done => { + const logController = new LoggerController(new WinstonLoggerAdapter()); + + Parse.Cloud.define('testFunction', (req, res) => { + res.success(1002,'verify code success'); + }); + + Parse.Cloud.run('testFunction', {username:'hawk',password:'123456'}) + .then(() => logController.getLogs({ from: Date.now() - 500, size: 1000 })) + .then((res) => { + const entry = res[0]; + expect(entry.params.password).toMatch(/\*\*\*\*\*\*\*\*/); + done(); + }) + .then(null, e => done.fail(e)); +});