From 7dfd18de2aa0a0b1123bf1e51532d69517befcd4 Mon Sep 17 00:00:00 2001 From: Manuel Trezza Date: Sat, 15 Aug 2020 14:02:00 +0200 Subject: [PATCH 1/2] replaced client_id with clientId --- spec/AuthenticationAdapters.spec.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/AuthenticationAdapters.spec.js b/spec/AuthenticationAdapters.spec.js index a42017769b..eaf628f38b 100644 --- a/spec/AuthenticationAdapters.spec.js +++ b/spec/AuthenticationAdapters.spec.js @@ -1244,7 +1244,7 @@ describe('apple signin auth adapter', () => { it('(using client id as array) should throw error with missing id_token', async () => { try { - await apple.validateAuthData({}, { client_id: ['secret'] }); + await apple.validateAuthData({}, { clientId: ['secret'] }); fail(); } catch (e) { expect(e.message).toBe('id token is invalid for this user.'); @@ -1328,7 +1328,7 @@ describe('apple signin auth adapter', () => { try { await apple.validateAuthData( { id: 'the_user_id', token: 'the_token' }, - { client_id: ['secret'] } + { clientId: ['secret'] } ); fail(); } catch (e) { @@ -1490,7 +1490,7 @@ describe('apple signin auth adapter', () => { // TODO: figure out a way to generate our own apple signed tokens, perhaps with a parse apple account // and a private key - xit('(using client id as string) should throw error with invalid jwt client_id', async () => { + xit('(using client id as string) should throw error with invalid jwt clientId', async () => { try { await apple.validateAuthData( { id: 'INSERT ID HERE', token: 'INSERT APPLE TOKEN HERE' }, @@ -1504,7 +1504,7 @@ describe('apple signin auth adapter', () => { // TODO: figure out a way to generate our own apple signed tokens, perhaps with a parse apple account // and a private key - xit('(using client id as array) should throw error with invalid jwt client_id', async () => { + xit('(using client id as array) should throw error with invalid jwt clientId', async () => { try { await apple.validateAuthData( { id: 'INSERT ID HERE', token: 'INSERT APPLE TOKEN HERE' }, From 603c67c924955ed3cc042b029b81aed5a821d301 Mon Sep 17 00:00:00 2001 From: Manuel Trezza Date: Tue, 25 Aug 2020 17:10:59 +0200 Subject: [PATCH 2/2] retroactively added breaking change to change log --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4f54fdaf7c..f4abc5f613 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -45,6 +45,10 @@ ### 4.2.0 [Full Changelog](https://github.com/parse-community/parse-server/compare/4.1.0...4.2.0) + +__BREAKING CHANGES:__ +- CHANGE: The Sign-In with Apple authentication adapter parameter `client_id` has been changed to `clientId`. If using the Apple authentication adapter, this change requires to update the Parse Server configuration accordingly. See [#6523](https://github.com/parse-community/parse-server/pull/6523) for details. +___ - UPGRADE: Parse JS SDK to 2.12.0 [#6548](https://github.com/parse-community/parse-server/pull/6548) - NEW: Support Group aggregation on multiple columns for Postgres [#6483](https://github.com/parse-community/parse-server/pull/6483). Thanks to [Siddharth Ramesh](https://github.com/srameshr). - FIX: Improve test reliability by instructing Travis to only install one version of Postgres [#6490](https://github.com/parse-community/parse-server/pull/6490). Thanks to