Skip to content

Commit f471374

Browse files
solved issue ocaml#416 and ocaml#417 short tasks (ocaml#426)
1 parent 049cf37 commit f471374

File tree

4 files changed

+29
-1
lines changed

4 files changed

+29
-1
lines changed

site/pages/principles/academic.res

+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
type t = {
2+
title: string,
3+
pageDescription: string,
4+
}
5+
6+
let contentEn = {
7+
title: `Academic Excellence`,
8+
pageDescription: ``,
9+
}
10+
11+
@react.component
12+
let make = (~content=contentEn) => <>
13+
<ConstructionBanner />
14+
<Page.Basic title=content.title pageDescription=content.pageDescription> {<> </>} </Page.Basic>
15+
</>
16+
17+
let default = make

site/pages/principles/academic.resi

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
type t = {
2+
title: string,
3+
pageDescription: string,
4+
}
5+
6+
@react.component
7+
let make: (~content: t=?) => React.element
8+
9+
let default: {"content": option<t>} => React.element

site/src/GlobalData.res

+2-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ let navContentEn = {
4545
},
4646
academicExcellence: {
4747
label: `Academic Excellence`,
48-
url: InternalUrls.principlesSuccesses /* TODO - point to correct page once it's created */,
48+
url: InternalUrls.principlesAcademic,
4949
icon: Icons.academic,
5050
text: "Learn about the academics that research programming language technology.",
5151
},
@@ -155,6 +155,7 @@ let footerContentEn: Footer.t = {
155155
entries: [
156156
navContentEn.principlesSection.whatIsOcaml,
157157
navContentEn.principlesSection.industrialUsers,
158+
navContentEn.principlesSection.academicExcellence,
158159
navContentEn.principlesSection.successStories,
159160
],
160161
},

site/src/InternalUrls.res

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ let communityNewsarchive = "/community/newsarchive"
99
let communityOpportunities = "/community/opportunities"
1010
let principlesSuccesses = "/principles/successes"
1111
let principlesIndustrialUsers = "/principles/users"
12+
let principlesAcademic = "/principles/academic"
1213
let principlesWhatisocaml = "/principles/whatisocaml"
1314
let legalCarbonfootprint = "/legal/carbonfootprint"
1415
let legalPrivacy = "/legal/privacy"

0 commit comments

Comments
 (0)