Skip to content

Commit dc0491a

Browse files
fix(pfNotificationDrawer): Do not add #0 to URL on close or expand
1 parent c2378a0 commit dc0491a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/notification/examples/notification-drawer.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
<li class="drawer-pf-trigger dropdown" ng-class="{'open': !hideDrawer}">
6565
<a class="nav-item-iconic drawer-pf-trigger-icon" ng-click="toggleShowDrawer()">
6666
<span class="fa fa-bell" title="Notifications"></span>
67-
<span ng-if="unreadNotifications" class="badge"> </span>
67+
<span ng-if="unreadNotifications" class="badge badge-pf-bordered"> </span>
6868
</a>
6969
</li>
7070
</ul>

src/notification/notification-drawer.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div class="drawer-pf" ng-class="{'hide': $ctrl.drawerHidden, 'drawer-pf-expanded': $ctrl.drawerExpanded}">
22
<div ng-if="$ctrl.drawerTitle" class="drawer-pf-title">
3-
<a href="#0" ng-if="$ctrl.allowExpand" class="drawer-pf-toggle-expand fa fa-angle-double-left hidden-xs" ng-click="$ctrl.toggleExpandDrawer()"></a>
4-
<a href="#0" ng-if="$ctrl.onClose" class="drawer-pf-close pficon pficon-close" ng-click="$ctrl.onClose()"></a>
3+
<a href="" ng-if="$ctrl.allowExpand" class="drawer-pf-toggle-expand fa fa-angle-double-left hidden-xs" ng-click="$ctrl.toggleExpandDrawer()"></a>
4+
<a href="" ng-if="$ctrl.onClose" class="drawer-pf-close pficon pficon-close" ng-click="$ctrl.onClose()"></a>
55
<h3 class="text-center">{{$ctrl.drawerTitle}}</h3>
66
</div>
77
<div ng-if="$ctrl.titleInclude" class="drawer-pf-title" ng-include src="$ctrl.titleInclude"></div>

test/notification/notification-drawer.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ describe('Component: pfNotificationDrawer', function () {
499499
var expandToggle = element.find('.drawer-pf-toggle-expand');
500500
expect(expandToggle.length).toBe(1);
501501

502-
eventFire(expandToggle[0], 'click');
502+
expandToggle[0].click();
503503
$scope.$digest();
504504

505505
expandedDrawer = element.find('.drawer-pf.drawer-pf-expanded');
@@ -529,7 +529,7 @@ describe('Component: pfNotificationDrawer', function () {
529529

530530
expect($scope.closed).toBe(false);
531531

532-
eventFire(closeButton[0], 'click');
532+
closeButton[0].click();
533533
$scope.$digest();
534534

535535
expect($scope.closed).toBe(true);

0 commit comments

Comments
 (0)