Accessibility: Notification drawer expand & collapse links are inaccessible via keyboard navigation

[benjaminapetersen]

The a ng-clicks in the header of the notification drawer need an empty href="" to be keyboard accessible (expand/collapse links).

Re this comment on origin-web-console PR 1326

Is there accessibility guidelines in upstream patternfly? This would be a great topic @ that level.

@jeff-phillips-18

[cdcabrera]

Quite a few potentials for this fix:

• Per @amarie401 , href="javascript:void(0)"
• dump a tab-index="0" on there (last resort)
• ng-href="" ng-click="someEvent"
• ng-href="" ng-click="someEvent($event)", and look at preventDefault in some form and maybe a hash in ng-href... though routing may be a concern

[jeff-phillips-18]

href="" will work just fine (in angular)

[cdcabrera]

href works... within some past projects, for future proofing, seen, and let Angular generate all of the attributes

[jeff-phillips-18]

I assume you mean you'd prefer to go with ng-href ? If so, I'm ok with that as well.

[jeff-phillips-18]

we don't want to simply tab-index="0" and we don't want to prevent default since we want to be able to activate these via the keyboard as well.

[cdcabrera]

agreed, the potential for funkiness is well, funky

Edit: for consistency if we haven't been using ng-href and defaulting to href probably a good idea to keep it the same