Skip to content

pfFilterPanel: responsiveness and accesibility #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtaylor113 opened this issue Aug 28, 2017 · 2 comments · Fixed by #674
Closed

pfFilterPanel: responsiveness and accesibility #600

dtaylor113 opened this issue Aug 28, 2017 · 2 comments · Fixed by #674
Assignees

Comments

@dtaylor113
Copy link
Member

dtaylor113 commented Aug 28, 2017

Some issues with margins/padding at mobile:

  1. Active Filters / Clear All Filters text is not left aligned with the filter values
  2. No top padding between filter values that wrap
  3. Attempted to import Bootstrap's variables.less file and use @media(max-width: @screen-md-min) to address responsiveness layout in the pfFilterPanel. A concern was: "if someone overrides bootstrap variables then includes a-pf less files, they will lose their overrides" We need to figure out, in general, how to address responsiveness in angular-patternfly.

In addition, the pfFilterPanel needs to updated to handle resposiveness.

openshift catalog components 2017-08-28 11-38-48

The clear button on the filter value is not accessible because the a doesn't have an href

openshift catalog components 2017-08-28 11-41-25

@dtaylor113
Copy link
Member Author

Attempted to import Bootstrap's variables.less file and use @media(max-width: @screen-md-min) to address responsiveness layout in the pfFilterPanel. A concern was: "if someone overrides bootstrap variables then includes a-pf less files, they will lose their overrides" We need to figure out, in general, how to address responsiveness in angular-patternfly.

@jeff-phillips-18, @andresgalante so looking at Patternfly core, I see may instances of using Bootstrap's @screen variables:

@media (max-width: @screen-sm-max) and @media (min-width: @screen-md-min)

Do we want to introduce patternfly @screen variables, ie: @pf-screen-md-min which will have less of a chance of being overwritten?

@jeff-phillips-18
Copy link
Member

@dtaylor113 I'd say just include the bootstrap less files. Adopters can include the less files in the order of their choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants