Notification drawer blank state styling wrong

[spadgett]

Looks like this was introduced in #587

cc @jeff-phillips-18 @benjaminapetersen

Before as h1:

After as h4:

[spadgett]

The original h1 seems more semantically correct to me. h4 seems arbitrary since there's no h1 / h2 / h3.

[benjaminapetersen]

Hm. Yeah I wonder if semantically it could have just been a p tag as its not really even a heading for content.

The top header area (test, view all events, 0 unread) is within an h4, btw. Reported here

[benjaminapetersen]

Running the demo locally looks like this:

The h1 class just affects the heading space. However, when we pull it into the console, it blows up the font size.

I do see .showcase classes appearing here and altering style as well, however, which might be related to what @jeff-phillips-18 mentioned on issue #607?

[jeff-phillips-18]

.showcase is a ng-docs page only thing. Just went in today. we will resolve it shortly.

[benjaminapetersen]

ok great!

[spadgett]

Yeah I wonder if semantically it could have just been a p tag as its not really even a heading for content.

Agree

The h1 class just affects the heading space. However, when we pull it into the console, it blows up the font size.

It looks like class="h1" in actually the problem in our console because of one of our styles

[cliffpyles]

According to the design spec, an empty state pattern requires a title. So from what I can tell, the larger font and spacing is actually the desired outcome (according to the spec). So do we need to deviate from the design spec, or should this be left as is? I'm attaching the design spec below for reference.

[jeff-phillips-18]

I think leaving it as an h4 should be OK, it is technically a header.

[cliffpyles]

Sounds good. I'll close the issue then.