Skip to content

Notification Drawer: Expanded View for PatternFly #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
LHinson opened this issue Aug 31, 2017 · 2 comments
Closed
1 of 2 tasks

Notification Drawer: Expanded View for PatternFly #405

LHinson opened this issue Aug 31, 2017 · 2 comments

Comments

@LHinson
Copy link
Member

LHinson commented Aug 31, 2017

For Pattern contribution proposal, tell us about your idea...

1. Choose the type of contribution for this pattern:

  • This is a new pattern
  • This is an enhancement on an existing pattern

2. If this enhancement or new pattern was made for an application, specify which one.

OpenShift

3. Title

Notification Drawer: Expanded View - Recommendations about the amount of content

Should be discussed whether this is a priority or required for PatternFly. This requirement surfaced when reviewing a recent notification drawer PR here: patternfly/patternfly#717

@LHinson
Copy link
Member Author

LHinson commented Aug 31, 2017

Adding @serenamarie125 to just take a look at this and advice.

@LHinson
Copy link
Member Author

LHinson commented Sep 2, 2017

@mcarrano @serenamarie125 After seeing how the implementation can handle additional content in a way that looks good [1], I don't think this is an issue. I was concerned when seeing skinny columns with lots of text however that has been resolved with layout adjustments.

[1] openshift/origin-web-console#1997

Closing this one.

@LHinson LHinson closed this as completed Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants