Skip to content

Navigation - add inert attribute to content within a collapsed group #11732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thatblindgeye opened this issue Apr 1, 2025 · 3 comments · May be fixed by #11749
Open

Navigation - add inert attribute to content within a collapsed group #11732

thatblindgeye opened this issue Apr 1, 2025 · 3 comments · May be fixed by #11749
Assignees
@Mash707
Labels
A11y PF Team

Comments

@thatblindgeye
Copy link
Contributor

Is this a new component or an extension of an existing one?
Navigation

Describe the feature
Related to the core fix for patternfly/patternfly#7431, we should add the inert attribute to further prevent hidden content within a collapsed NavExpandable from being focused (specifically on the navSubnav element)

This should include a test (probably Cypress?) to check that content in an expanded NavExpandable can be focused, and cannot be focused when collapsed.

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
Include screenshots or links to Marvel or other mockups.

Any other information?
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Apr 1, 2025
@Mash707
Copy link
Contributor

Mash707 commented Apr 6, 2025

@thatblindgeye are we talking about adding the inert attribute in the section part? make it null or true just like hidden based on expandedState

patternfly-react/packages/react-core/src/components/Nav/NavExpandable.tsx

Lines 144 to 153 in 4ea82f7

<section className={css(styles.navSubnav)} aria-labelledby={this.id} hidden={expandedState ? null : true}>
{srText && (
<h2 className="pf-v6-screen-reader" id={this.id}>
{srText}
</h2>
)}
<ul className={css(styles.navList)} role="list">
{children}
</ul>
</section>

@thatblindgeye
Copy link
Contributor Author

@Mash707 yep that's correct

@kmcfaul kmcfaul added the A11y label Apr 8, 2025
@kmcfaul kmcfaul moved this from Needs triage to Backlog in PatternFly Issues Apr 8, 2025
@Mash707 Mash707 linked a pull request Apr 9, 2025 that will close this issue
Open
@Mash707
Copy link
Contributor

Mash707 commented Apr 9, 2025

@kmcfaul working on this, could you assign this to me. Thank You

@thatblindgeye thatblindgeye moved this from Backlog to PR Review in PatternFly Issues Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mash707 Mash707

Labels
A11y PF Team
Projects
PatternFly Issues
Status: PR Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(navigation) - add inert attribute to NavExpandable Mash707/patternfly-react
3 participants
@kmcfaul @thatblindgeye @Mash707