Skip to content

Chrome 41: Math.asinh and Math.atanh are imprecise #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ljharb opened this issue Apr 14, 2015 · 7 comments
Closed

Chrome 41: Math.asinh and Math.atanh are imprecise #334

ljharb opened this issue Apr 14, 2015 · 7 comments

Comments

@ljharb
Copy link
Collaborator

ljharb commented Apr 14, 2015

var isAsinhOK = Math.asinh(0.0002) >= 0.0001999999986666666 &&  Math.asinh(0.0002) <= 0.0001999999986666668;
var isAtanhOK = Math.atanh(0.0002) >= 0.0002000000026666667 && Math.atanh(0.0002) <= 0.0002000000026666668;

Both of these are true in shimmed Firefox 37 and Safari 8, both false in Chrome 41 and Chrome Canary 44.

From compat-table/compat-table#392 (comment)

@ljharb
Copy link
Collaborator Author

ljharb commented Apr 14, 2015

@Yaffle Note that our actual asinh and atanh shims fail this test also.

@Yaffle
Copy link
Contributor

Yaffle commented Jan 14, 2017

@anematode
Copy link

It looks like this issue is fixed; probably should close the issue?

@Yaffle
Copy link
Contributor

Yaffle commented Aug 24, 2020

yes

@ljharb
Copy link
Collaborator Author

ljharb commented Aug 24, 2020

When (or in what PR/commit) was it fixed?

@Yaffle
Copy link
Contributor

Yaffle commented Aug 24, 2020

ec76d49

@Yaffle Yaffle mentioned this issue Aug 25, 2020
Closed
@ljharb
Copy link
Collaborator Author

ljharb commented Aug 25, 2020

Thanks!

Fixed in ec76d49, then.

@ljharb ljharb closed this as completed Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants