Skip to content

Commit 90780ec

Browse files
committed
DROPME - temporarily upgrade to numpy-1.24.2
Temporarily upgrade to numpy-1.24.2 to enable CI testing of quantumlib#5991. Restrict CI-tests to Python 3.8 only which permits installation of numpy-1.24.2 and numba. Note numba is not yet compatible with numpy-1.24 and its import raises SystemError exception SystemError: initialization of _internal failed without raising an exception Here we also add intentionally failing CI check to ensure this commit is not accidentally merged to master. Please revert this commit before merging the pull-request.
1 parent 38385b5 commit 90780ec

File tree

2 files changed

+20
-4
lines changed

2 files changed

+20
-4
lines changed

.github/workflows/ci.yml

+14-3
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ jobs:
149149
name: Pytest Ubuntu
150150
strategy:
151151
matrix:
152-
python-version: [ '3.7', '3.8', '3.9', '3.10' ]
152+
python-version: [ '3.8' ]
153153
runs-on: ubuntu-20.04
154154
steps:
155155
- uses: actions/checkout@v2
@@ -185,6 +185,17 @@ jobs:
185185
- name: Test dependencies with pip-compile
186186
run: |
187187
pip-compile --resolver=backtracking dev_tools/requirements/deps/cirq-all.txt -o-
188+
numpy-1_24-guard:
189+
name: Deliberate failure for numpy-1.24
190+
runs-on: ubuntu-20.04
191+
steps:
192+
- uses: actions/checkout@v2
193+
- name: Exit with error status
194+
run: |
195+
echo "This check fails to prevent merging of a temporary upgrade to numpy-1.24"
196+
echo
197+
echo "Please revert the commit which introduced this test."
198+
exit 1
188199
build_docs:
189200
name: Build docs
190201
runs-on: ubuntu-20.04
@@ -244,7 +255,7 @@ jobs:
244255
name: Pytest Windows
245256
strategy:
246257
matrix:
247-
python-version: [ '3.7', '3.8', '3.9', '3.10' ]
258+
python-version: [ '3.8' ]
248259
runs-on: windows-2019
249260
steps:
250261
- uses: actions/checkout@v2
@@ -269,7 +280,7 @@ jobs:
269280
name: Pytest MacOS
270281
strategy:
271282
matrix:
272-
python-version: [ '3.7', '3.8', '3.9', '3.10' ]
283+
python-version: [ '3.8' ]
273284
runs-on: macos-12
274285
steps:
275286
- uses: actions/checkout@v2

cirq-core/requirements.txt

+6-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,12 @@ backports.cached_property~=1.0.1; python_version < '3.8'
66
duet~=0.2.7
77
matplotlib~=3.0
88
networkx~=2.4
9-
numpy>=1.16,<1.24
9+
10+
# Here we temporarily bump-up to numpy-1.24 for sake of CI testing
11+
# TODO(#5991) - revert this change before merge
12+
# numpy>=1.16,<1.24
13+
numpy==1.24.2
14+
1015
pandas
1116
sortedcontainers~=2.0
1217
scipy

0 commit comments

Comments
 (0)