-
-
Notifications
You must be signed in to change notification settings - Fork 31
Add dataclass and pydantic support #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great! I will review this tomorrow 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good 👍
If we can get rid of the pydantic dependency this would be great. I'd rename field
property to the more explicit pydantic-field
, and add a pydantic-model
property on such classes as well 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a few things left 🙂
Thanks again @shyamd! Really appreciate your contributions! |
This PR adds support for parsing dataclass annotations and PyDantic fields as attributes of a class.