Skip to content

Commit 3daf8e1

Browse files
committed
- Remove failing spec
- Improve readme
1 parent 1379038 commit 3daf8e1

File tree

2 files changed

+26
-4
lines changed

2 files changed

+26
-4
lines changed

README.md

+26-1
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,35 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
6060

6161
To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release` to create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
6262

63+
## Maintenance
64+
65+
To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release` to create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
66+
67+
## Versioning
68+
69+
This library aims to adhere to [Semantic Versioning 2.0.0](http://semver.org/).
70+
Violations of this scheme should be reported as bugs. Specifically,
71+
if a minor or patch version is released that breaks backward
72+
compatibility, a new version should be immediately released that
73+
restores compatibility. Breaking changes to the public API will
74+
only be introduced with new major versions.
75+
76+
As a result of this policy, you can (and should) specify a
77+
dependency on this gem using the [Pessimistic Version Constraint](http://docs.rubygems.org/read/chapter/16#page74) with two digits of precision.
78+
79+
For example:
80+
81+
spec.add_dependency 'destination_errors', '~> 0.0'
82+
6383
## Contributing
6484

6585
1. Fork it ( https://github.com/[my-github-username]/react-rails-benchmark_renderer/fork )
6686
2. Create your feature branch (`git checkout -b my-new-feature`)
6787
3. Commit your changes (`git commit -am 'Add some feature'`)
6888
4. Push to the branch (`git push origin my-new-feature`)
69-
5. Create a new Pull Request
89+
5. Make sure to add tests!
90+
6. Create a new Pull Request
91+
92+
## Contributors
93+
94+
See the [Network View](https://github.com/pboling/react-rails-benchmark_renderer/network)

spec/react/rails/benchmark_renderer_spec.rb

-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,4 @@
55
expect(React::Rails::BenchmarkRenderer::VERSION).not_to be nil
66
end
77

8-
it 'does something useful' do
9-
expect(false).to eq(true)
10-
end
118
end

0 commit comments

Comments
 (0)