Skip to content

Commit c166bc0

Browse files
author
Pedro Crespo
committed
Fixes makefile filter (see previous commit)
Removed deprecated modules from merge Fixed container_environ fixture Added +x to entrypoint.sh otherwise container does not have execution permissions
1 parent 05d5423 commit c166bc0

File tree

5 files changed

+4
-85
lines changed

5 files changed

+4
-85
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export HOST_GID=1000
2828
# TODO: Add a meaningfull call to retrieve the local docker group ID and the user ID in linux.
2929
endif
3030

31-
PY_FILES = $(strip $(shell find services packages -iname '*.py' -not -path "*egg*" -not -path "*contrib*" -not -path "*-sdk/python*" -not -path "*generated_code*" -not -path "*datcore.py" -not -path "web/server"))
31+
PY_FILES = $(strip $(shell find services packages -iname '*.py' -not -path "*egg*" -not -path "*contrib*" -not -path "*-sdk/python*" -not -path "*generated_code*" -not -path "*datcore.py" -not -path "*web/server*"))
3232

3333
export PYTHONPATH=${CURDIR}/packages/s3wrapper/src:${CURDIR}/packages/simcore-sdk/src
3434

services/sidecar/docker/entrypoint.sh

100644100755
File mode changed.

services/web/server/src/simcore_service_webserver/director.py

-41
This file was deleted.

services/web/server/src/simcore_service_webserver/director_config.py

-41
This file was deleted.

services/web/server/tests/unit/test_configs.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def devel_environ(env_devel_file):
5252

5353

5454
@pytest.fixture("session")
55-
def container_environ(services_docker_compose_file, devel_environ):
55+
def container_environ(services_docker_compose_file, devel_environ, osparc_simcore_root_dir):
5656
""" Creates a dict with the environment variables
5757
inside of a webserver container
5858
"""
@@ -61,7 +61,8 @@ def container_environ(services_docker_compose_file, devel_environ):
6161
dc = yaml.safe_load(f)
6262

6363
container_environ = {
64-
'SIMCORE_WEB_OUTDIR': 'home/scu/services/web/client' # defined in Dockerfile
64+
'SIMCORE_WEB_OUTDIR': 'home/scu/services/web/client', # defined in Dockerfile
65+
'OSPARC_SIMCORE_REPO_ROOTDIR': str(osparc_simcore_root_dir) # defined if pip install --edit (but not in travis!)
6566
}
6667

6768
environ_items = dc["services"]["webserver"]["environment"]

0 commit comments

Comments
 (0)