prevented organizeImports appending an extra new line to declarations at end of a file

relates microsoft#48126

Author: pflannery

src/services/textChanges.ts

@@ -1275,7 +1275,15 @@ namespace changesToText {
                 const targetSourceFile = c.kind === ChangeKind.ReplaceWithSingleNode ? getSourceFileOfNode(getOriginalNode(c.node)) ?? c.sourceFile :
                     c.kind === ChangeKind.ReplaceWithMultipleNodes ? getSourceFileOfNode(getOriginalNode(c.nodes[0])) ?? c.sourceFile :
                     c.sourceFile;
-                const newText = computeNewText(c, targetSourceFile, sourceFile, newLineCharacter, formatContext, validate);
+                let newText = computeNewText(c, targetSourceFile, sourceFile, newLineCharacter, formatContext, validate);
+
+                // prevent appending an extra new line to declarations at end of a file
+                const spanTextEnd = span.start + newText.length;
+                const isEndOfFile = span.length !== 0 && (spanTextEnd - newLineCharacter.length) === targetSourceFile.text.length;
+                if (c.kind === ChangeKind.ReplaceWithMultipleNodes && isEndOfFile && endsWith(newText, newLineCharacter)) {
+                    newText = newText.substring(0, newText.length - newLineCharacter.length);
+                }
+
                 // Filter out redundant changes.
                 if (span.length === newText.length && stringContainsAt(targetSourceFile.text, newText, span.start)) {
                     return undefined;

tests/baselines/reference/organizeImports/TypeOnly.ts

@@ -12,4 +12,4 @@ import type Y from "lib";
 import type { A, B } from "lib";
 import { X, Z } from "lib";
 
-export { A, B, X, Y, Z };
+export { A, B, X, Y, Z };

tests/cases/fourslash/organizeImports12.ts

@@ -9,5 +9,5 @@
 verify.organizeImports(
 `declare export default class A {}
 declare export * from "foo";
-declare export { a, b };
-`);
+declare export { a, b };`
+);

tests/cases/fourslash/organizeImports17.ts

@@ -5,8 +5,7 @@
 
 verify.organizeImports(
 `import { case, Insensitively, sorted } from "aardvark";
-import { Both } from "module-specifiers-unsorted";
-`,
+import { Both } from "module-specifiers-unsorted";`,
     ts.OrganizeImportsMode.SortAndCombine,
     {
         organizeImportsIgnoreCase: "auto",

tests/cases/fourslash/organizeImports18.ts

@@ -29,5 +29,5 @@ export { C } from "./C";
 
 export { bFuncA } from "./A";
 export { bFuncB } from "./B";
-export { bFuncC } from "./C";
-`);
+export { bFuncC } from "./C";`
+);

tests/cases/fourslash/organizeImports19.ts

@@ -17,5 +17,5 @@ const b = 1;
 export { b };
 
 const c = 1;
-export { c };
-`);
+export { c };`
+);

tests/cases/fourslash/organizeImportsType12.ts

@@ -0,0 +1,14 @@
+/// <reference path='fourslash.ts' />
+
+// @allowSyntheticDefaultImports: true
+// @moduleResolution: node
+// @noUnusedLocals: true
+// @target: es2018
+
+//// export * from './file2.js';
+//// export * from './file1.js';
+
+verify.organizeImports(
+`export * from './file1.js';
+export * from './file2.js';`
+);

tests/cases/fourslash/organizeImportsType13.ts

@@ -0,0 +1,20 @@
+/// <reference path='fourslash.ts' />
+
+// @allowSyntheticDefaultImports: true
+// @moduleResolution: node
+// @noUnusedLocals: true
+// @target: es2018
+
+//// export * from './file4.js';
+//// export * from './file3.js';
+////
+//// export * from './file2.js';
+//// export * from './file1.js';
+
+verify.organizeImports(
+`export * from './file3.js';
+export * from './file4.js';
+
+export * from './file1.js';
+export * from './file2.js';`
+);

tests/cases/fourslash/organizeImportsType2.ts

@@ -15,16 +15,14 @@ verify.organizeImports(
 `type A = string;
 type B = string;
 const C = "hello";
-export { A, C, type B };
-`
+export { A, C, type B };`
 );
 
 verify.organizeImports(
 `type A = string;
 type B = string;
 const C = "hello";
-export { A, type B, C };
-`,
+export { A, type B, C };`,
     undefined, 
     { organizeImportsTypeOrder : "inline" }
 );
@@ -33,8 +31,7 @@ verify.organizeImports(
 `type A = string;
 type B = string;
 const C = "hello";
-export { type B, A, C };
-`,
+export { type B, A, C };`,
     undefined, 
     { organizeImportsTypeOrder : "first" }
 );
@@ -43,8 +40,7 @@ verify.organizeImports(
 `type A = string;
 type B = string;
 const C = "hello";
-export { A, C, type B };
-`,
+export { A, C, type B };`,
     undefined, 
     { organizeImportsTypeOrder : "last" }
 );