Skip to content

Commit 31c2fde

Browse files
committed
chore: correct wrongly applied (due to Liquibase bug) to the fields (instead of the tables) comments
In the commit 89ba68c (#1326) I used <setColumnRemarks> in order to put comments to the fields. It has turned out that on MySQL, Liquibase put comments on the tables instead of the fields (see liquibase/liquibase#942). After update of Liquibase (#1526), it became possible to fix the bug on our data. Fix #1408
1 parent 2ab115a commit 31c2fde

File tree

2 files changed

+42
-0
lines changed

2 files changed

+42
-0
lines changed

src/main/resources/liquibase/version/0.4.7.xml

+1
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,6 @@
77

88
<include file="0.4.7/2021-07-18--series_import_parsed_image_urls.xml" relativeToChangelogFile="true" />
99
<include file="0.4.7/2021-11-28--series_and_nullable_perforated_field.xml" relativeToChangelogFile="true" />
10+
<include file="0.4.7/2022-09-08--re_apply_column_comments.xml" relativeToChangelogFile="true" />
1011

1112
</databaseChangeLog>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<databaseChangeLog
3+
xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
4+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
5+
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
6+
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd">
7+
8+
<!--
9+
Re-apply changes from "0.4.4/2020-05-23--modify_condition_field.xml" and put comments to the fields instead of the tables.
10+
See for details: https://github.com/liquibase/liquibase/pull/942
11+
-->
12+
13+
<changeSet id="put-comment-on-collections_series-field-instead-of-on-table" author="php-coder" context="scheme" dbms="mysql">
14+
15+
<setColumnRemarks
16+
tableName="collections_series"
17+
columnName="cond"
18+
columnDataType="VARCHAR(9)"
19+
remarks="Example: MNH, CANCELLED" />
20+
21+
<setTableRemarks
22+
tableName="collections_series"
23+
remarks="" />
24+
25+
</changeSet>
26+
27+
<changeSet id="put-comment-on-series_sales-field-instead-of-on-table" author="php-coder" context="scheme" dbms="mysql">
28+
29+
<setColumnRemarks
30+
tableName="series_sales"
31+
columnName="cond"
32+
columnDataType="VARCHAR(9)"
33+
remarks="Example: MNH, CANCELLED" />
34+
35+
<setTableRemarks
36+
tableName="series_sales"
37+
remarks="" />
38+
39+
</changeSet>
40+
41+
</databaseChangeLog>

0 commit comments

Comments
 (0)