fix: show custom error page for 400 Bad Request errors

Fix #1351

Author: php-coder

Diff for: src/main/java/ru/mystamps/web/config/MvcConfig.java

@@ -108,6 +108,7 @@ public void configureDefaultServletHandling(DefaultServletHandlerConfigurer conf
 	public void addViewControllers(ViewControllerRegistry registry) {
 		registry.addViewController(AccountUrl.AUTHENTICATION_PAGE);
 		registry.addViewController(SiteUrl.FORBIDDEN_PAGE).setViewName("error/status-code");
+		registry.addViewController(SiteUrl.BAD_REQUEST_PAGE).setViewName("error/status-code");
 	}
 
 	@Override

Diff for: src/main/java/ru/mystamps/web/feature/site/SiteUrl.java

@@ -39,6 +39,7 @@ public final class SiteUrl {
 	public static final String SITE_EVENTS_PAGE    = "/site/events";
 	public static final String CSP_REPORTS_HANDLER = "/site/csp/reports";
 
+	public static final String BAD_REQUEST_PAGE    = "/error/400";
 	public static final String FORBIDDEN_PAGE      = "/error/403";
 	public static final String NOT_FOUND_PAGE      = "/error/404";
 	public static final String INTERNAL_ERROR_PAGE = "/error/500";

Diff for: src/main/java/ru/mystamps/web/support/spring/boot/ErrorPagesCustomizer.java

@@ -31,6 +31,7 @@ public class ErrorPagesCustomizer implements ErrorPageRegistrar {
 	@Override
 	public void registerErrorPages(ErrorPageRegistry registry) {
 		registry.addErrorPages(
+			new ErrorPage(HttpStatus.BAD_REQUEST, SiteUrl.BAD_REQUEST_PAGE),
 			new ErrorPage(HttpStatus.FORBIDDEN, SiteUrl.FORBIDDEN_PAGE),
 			new ErrorPage(HttpStatus.NOT_FOUND, SiteUrl.NOT_FOUND_PAGE),
 			new ErrorPage(RequestRejectedException.class, SiteUrl.NOT_FOUND_PAGE),

Diff for: src/main/resources/ru/mystamps/i18n/Messages.properties

@@ -98,6 +98,8 @@ t_activation_key = Activation key
 t_register = Register
 
 # error/status-code.html
+t_400_title = 400: bad request
+t_400_description = Bad request
 t_403_title = 403: forbidden
 t_403_description = Forbidden
 t_404_title = 404: page not found

Diff for: src/main/resources/ru/mystamps/i18n/Messages_ru.properties

@@ -98,6 +98,8 @@ t_activation_key = Код активации
 t_register = Зарегистрироваться
 
 # error/status-code.html
+t_400_title = 400: некорректный запрос
+t_400_description = Некорректный запрос
 t_403_title = 403: доступ запрещён
 t_403_description = Доступ запрещён
 t_404_title = 404: страница не найдена

Diff for: src/main/webapp/WEB-INF/views/error/status-code.html

@@ -10,6 +10,7 @@
 		<meta name="robots" content="noindex" />
 		<!--/*/
 			<th:block th:switch="${#response.status}">
+			<title th:case="'400'" th:text="#{t_400_title}">400: bad request</title>
 			<title th:case="'403'" th:text="#{t_403_title}">403: forbidden</title>
 			<title th:case="'404'" th:text="#{t_404_title}">404: page not found</title>
 		/*/-->
@@ -64,6 +65,9 @@ <h1 id="error-code" th:text="${#response.status}">
 					</h1>
 					<h4 id="error-msg" th:switch="${#response.status}">
 						<!--/*/
+						<span th:case="'400'" th:text="#{t_400_description}" th:remove="tag">
+							Bad request
+						</span>
 						<span th:case="'403'" th:text="#{t_403_description}" th:remove="tag">
 							Forbidden
 						</span>

Diff for: src/test/robotframework/site/error/misc.robot

@@ -0,0 +1,18 @@
+*** Settings ***
+Documentation    Verify error pages
+Library          SeleniumLibrary
+Suite Setup      Before Test Suite
+Suite Teardown   Close Browser
+Force Tags       error-page  misc
+
+*** Test Cases ***
+Client should see a custom page for Bad Request error
+	Title Should Be         400: bad request
+	Element Text Should Be  id:error-code  400
+	Element Text Should Be  id:error-msg   Bad request
+
+*** Keywords ***
+Before Test Suite
+	Open Browser                        ${SITE_URL}/series/info  ${BROWSER}
+	Register Keyword To Run On Failure  Log Source
+