Skip to content

Commit 9c7b457

Browse files
authored
chore(docs/decisions-log.md): document decision regarding suggestion links
[skip ci]
1 parent fcdb3e4 commit 9c7b457

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Diff for: docs/decisions-log.md

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
| 30.12.2017 Workaround | [php-coder/mystamps#772](https://github.com/php-coder/mystamps/issues/772) Because **Travis CI** has **MySQL** version 5.6.43, we can't have a unique index on a column that has a length that exceeds 767 bytes. Our production server is running on 5.7.20 that doesn't have such limitation. In order to be able to run migrations on all the environments, I set type of the `series_import_requests.url` column to `VARCHAR(767)` (instead of `VARCHAR(768)` or `VARCHAR(1024)` as I wanted before). Commits: [33dd9025](https://github.com/php-coder/mystamps/commit/33dd902500501d3fdc3a744229ad921982adbc01) |
2121
| 20.07.2017 Decision | [php-coder/mystamps#423](https://github.com/php-coder/mystamps/issues/423) Most of our **checks on CI** now get executed only when files of a certain type were modified. This should give us a faster feedback loop. Checks are also being run when their configuration has been changed. If check performed by a maven plugin, it will be always run when `pom.xml` is modified. The same logic applies to the tools that are being installed from the `.travis.yml` file. Unfortunately, we have to unconditionally run checks even if a change in a file wasn't related to the plugin/tool configuration. Also there is no way to disable skipping logic and if you need to run a specific check there is no way to force its execution. I was thinking about introducing an environment variable or using a special magic comment from a commit message but I decided to leave it as-is for a now (although it can be added later). Commits: [7da91a53](https://github.com/php-coder/mystamps/commit/7da91a53a1d7f43670d67adfce359814fa7ee27a) |
2222
| 29.05.2017 Workaround | [php-coder/mystamps#588](https://github.com/php-coder/mystamps/issues/588) In order to import **test image** into database I had to move the image file from `src/test/resources` to `src/main/resources` directory because **Liquibase** is executing during the startup and it doesn't distinguish between test and main resources (it just searches in a class path). Commits: [646bb167](https://github.com/php-coder/mystamps/commit/646bb16706d3dc41fe8d613f101ac6679ac5cc92) |
23+
| 06.05.2017 Decision | [php-coder/mystamps#517](https://github.com/php-coder/mystamps/issues/517) When we were implementing a suggestion link on the `/series/add` page, we had 2 options: return a suggestions as part of a page or request it later, as AJAX call, when page will be loaded in a browser. We have decided to stick with a second approach because **suggestion feature** is optional. We don't want to make more queries on the server side during page rendering. Commit: [9827abb9](https://github.com/php-coder/mystamps/commit/9827abb910f24432811017516d0a8f36d517752d) |
2324
| 08.04.2017 Decision | At present we have 4 tests that are failing time to time. Until we fix them completely, they might fail builds and show PRs as having errors. Because **flaky tests** don't relate to code from PRs, this fact might frustrate contributors. To improve this situation I introduced **a special tag `unstable`** that can be added to flaky tests to ignore their failures. Commits: [56e848f7](https://github.com/php-coder/mystamps/commit/56e848f73b7a06691b886d4be156e3f95752afc0) |
2425
| ~~24.02.2017 Workaround~~ | ~~[php-coder/mystamps#538](https://github.com/php-coder/mystamps/issues/538) `sed` (from Ubuntu 12.04) that is installed in **Travis CI** doesn't support `-z` option. I had to rewrite script on Perl as a workaround. Commits: [feea131a](https://github.com/php-coder/mystamps/commit/feea131a36f0cbae5c31a3826c4d061c878fe114), [aab6c7d9](https://github.com/php-coder/mystamps/commit/aab6c7d9735e7ae30d3434d27cda75832963a564), [54152eb2](https://github.com/php-coder/mystamps/commit/54152eb22bbfff1875afdadb9aac5b527a77bbeb)~~<br/> UPDATE(21.01.2020): because a proper solution has been found, the script, that we used as a workaround, has been removed in [e6ed0e85](https://github.com/php-coder/mystamps/commit/e6ed0e855f342abff2c5b1d3b3ac356d3dec2a47) |
2526
| 06.01.2017 Workaround | [php-coder/mystamps#434](https://github.com/php-coder/mystamps/issues/434) I was needed to render categories with its subcategories. Database returns data in a form (sub category name + category name or null). It turns out that it's impossible to render this data with **Thymeleaf** as a `<select>` with `<optgroup>` elements. I had to do data transformation inside of a service method. Commits: [b7fe1dac](https://github.com/php-coder/mystamps/commit/b7fe1dac7a7f0bc09e9e153a8408687fd899c79f) Example: https://gist.github.com/php-coder/d3020e4d8d00b8c5befe755c46f06f1b |

0 commit comments

Comments
 (0)