Skip to content

Commit aaf8ab8

Browse files
committed
refactor: change type of SitemapInfoDto.id from Integer to String
Required for containing slugs of entities like collection, category etc Part of #1605
1 parent 88a0f56 commit aaf8ab8

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

Diff for: src/main/java/ru/mystamps/web/feature/series/RowMappers.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ private RowMappers() {
3737
throws SQLException {
3838

3939
return new SitemapInfoDto(
40-
rs.getInt("id"),
40+
rs.getString("id"),
4141
rs.getTimestamp("updated_at")
4242
);
4343
}

Diff for: src/main/java/ru/mystamps/web/feature/series/SitemapInfoDto.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@
2727
@ToString
2828
@RequiredArgsConstructor
2929
public class SitemapInfoDto {
30-
private final Integer id;
30+
private final String id;
3131
private final Date updatedAt;
3232
}

Diff for: src/main/java/ru/mystamps/web/feature/site/SitemapController.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ private static String createUrlEntry(DateFormat dateFormatter, SitemapInfoDto it
8787

8888
private static String createLocEntry(SitemapInfoDto item) {
8989
return SiteUrl.PUBLIC_URL
90-
+ SeriesUrl.INFO_SERIES_PAGE.replace("{id}", String.valueOf(item.getId()));
90+
+ SeriesUrl.INFO_SERIES_PAGE.replace("{id}", item.getId());
9191
}
9292

9393
private static String createLastModEntry(DateFormat dateFormatter, SitemapInfoDto item) {

Diff for: src/test/java/ru/mystamps/web/service/TestObjects.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public static ImageDto createImageDto() {
137137
}
138138

139139
public static SitemapInfoDto createSitemapInfoDto() {
140-
return new SitemapInfoDto(Random.id(), Random.date());
140+
return new SitemapInfoDto(String.valueOf(Random.id()), Random.date());
141141
}
142142

143143
@SuppressWarnings("checkstyle:magicnumber")

0 commit comments

Comments
 (0)