Skip to content

LinkEntityDto: remove id member #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
php-coder opened this issue Aug 15, 2016 · 2 comments
Open

LinkEntityDto: remove id member #441

php-coder opened this issue Aug 15, 2016 · 2 comments
Labels
refactoring
Milestone
next

Comments

@php-coder
Copy link
Owner

LinkEntityDto holds id, slug and name members that are used for building URLs. After migration to URLs with slugs (#205, #206, #207) we don't use id and I think that we can remove it.
@php-coder php-coder modified the milestone: next Aug 15, 2016
@php-coder
Copy link
Owner Author

Also we should find&replace all occurrences of category.id and country.id in Thymeleaf templates.

@php-coder
Copy link
Owner Author

Another idea is to replace it by EntityWithSlugDto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@php-coder