[job-queue] sync with latest design changes.

Author: makasim

CalculateRootJobStatusProcessor.php

@@ -2,8 +2,8 @@
 
 namespace Enqueue\JobQueue;
 
+use Enqueue\Client\CommandSubscriberInterface;
 use Enqueue\Client\ProducerInterface;
-use Enqueue\Client\TopicSubscriberInterface;
 use Enqueue\Consumption\Result;
 use Enqueue\JobQueue\Doctrine\JobStorage;
 use Enqueue\Util\JSON;
@@ -12,7 +12,7 @@
 use Interop\Queue\PsrProcessor;
 use Psr\Log\LoggerInterface;
 
-class CalculateRootJobStatusProcessor implements PsrProcessor, TopicSubscriberInterface
+class CalculateRootJobStatusProcessor implements PsrProcessor, CommandSubscriberInterface
 {
     /**
      * @var JobStorage
@@ -34,12 +34,6 @@ class CalculateRootJobStatusProcessor implements PsrProcessor, TopicSubscriberIn
      */
     private $logger;
 
-    /**
-     * @param JobStorage                    $jobStorage
-     * @param CalculateRootJobStatusService $calculateRootJobStatusCase
-     * @param ProducerInterface             $producer
-     * @param LoggerInterface               $logger
-     */
     public function __construct(
         JobStorage $jobStorage,
         CalculateRootJobStatusService $calculateRootJobStatusCase,
@@ -52,9 +46,6 @@ public function __construct(
         $this->logger = $logger;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function process(PsrMessage $message, PsrContext $context)
     {
         $data = JSON::decode($message->getBody());
@@ -83,11 +74,8 @@ public function process(PsrMessage $message, PsrContext $context)
         return Result::ACK;
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public static function getSubscribedTopics()
+    public static function getSubscribedCommand()
     {
-        return [Topics::CALCULATE_ROOT_JOB_STATUS];
+        return Commands::CALCULATE_ROOT_JOB_STATUS;
     }
 }

Commands.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Enqueue\JobQueue;
+
+class Commands
+{
+    const CALCULATE_ROOT_JOB_STATUS = 'enqueue.message_queue.job.calculate_root_job_status';
+}

DependentJobProcessor.php

@@ -111,11 +111,8 @@ public function process(PsrMessage $message, PsrContext $context)
         return Result::ACK;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public static function getSubscribedTopics()
     {
-        return [Topics::ROOT_JOB_STOPPED];
+        return Topics::ROOT_JOB_STOPPED;
     }
 }

JobProcessor.php

@@ -260,7 +260,7 @@ protected function saveJob(Job $job)
      */
     protected function sendCalculateRootJobStatusEvent(Job $job)
     {
-        $this->producer->sendEvent(Topics::CALCULATE_ROOT_JOB_STATUS, [
+        $this->producer->sendEvent(Commands::CALCULATE_ROOT_JOB_STATUS, [
             'jobId' => $job->getId(),
         ]);
     }

Tests/CalculateRootJobStatusProcessorTest.php

@@ -6,6 +6,7 @@
 use Enqueue\Consumption\Result;
 use Enqueue\JobQueue\CalculateRootJobStatusProcessor;
 use Enqueue\JobQueue\CalculateRootJobStatusService;
+use Enqueue\JobQueue\Commands;
 use Enqueue\JobQueue\Doctrine\JobStorage;
 use Enqueue\JobQueue\Job;
 use Enqueue\JobQueue\Topics;
@@ -28,8 +29,8 @@ public function testCouldBeConstructedWithRequiredArguments()
     public function testShouldReturnSubscribedTopicNames()
     {
         $this->assertEquals(
-            [Topics::CALCULATE_ROOT_JOB_STATUS],
-            CalculateRootJobStatusProcessor::getSubscribedTopics()
+            Commands::CALCULATE_ROOT_JOB_STATUS,
+            CalculateRootJobStatusProcessor::getSubscribedCommand()
         );
     }
 

Tests/DependentJobProcessorTest.php

@@ -18,7 +18,7 @@ class DependentJobProcessorTest extends \PHPUnit\Framework\TestCase
     public function testShouldReturnSubscribedTopicNames()
     {
         $this->assertEquals(
-            [Topics::ROOT_JOB_STOPPED],
+            Topics::ROOT_JOB_STOPPED,
             DependentJobProcessor::getSubscribedTopics()
         );
     }

Tests/JobProcessorTest.php

@@ -3,11 +3,11 @@
 namespace Enqueue\JobQueue\Tests;
 
 use Enqueue\Client\ProducerInterface;
+use Enqueue\JobQueue\Commands;
 use Enqueue\JobQueue\Doctrine\JobStorage;
 use Enqueue\JobQueue\DuplicateJobException;
 use Enqueue\JobQueue\Job;
 use Enqueue\JobQueue\JobProcessor;
-use Enqueue\JobQueue\Topics;
 use PHPUnit\Framework\TestCase;
 
 class JobProcessorTest extends TestCase
@@ -170,7 +170,7 @@ public function testCreateChildJobShouldCreateAndSaveJobAndPublishRecalculateRoo
         $producer
             ->expects($this->once())
             ->method('sendEvent')
-            ->with(Topics::CALCULATE_ROOT_JOB_STATUS, ['jobId' => 12345])
+            ->with(Commands::CALCULATE_ROOT_JOB_STATUS, ['jobId' => 12345])
         ;
 
         $processor = new JobProcessor($storage, $producer);

Topics.php

@@ -4,6 +4,5 @@
 
 class Topics
 {
-    const CALCULATE_ROOT_JOB_STATUS = 'enqueue.message_queue.job.calculate_root_job_status';
     const ROOT_JOB_STOPPED = 'enqueue.message_queue.job.root_job_stopped';
 }