Skip to content

Commit a64dc79

Browse files
committed
Removing constructor tests
Removing all tests that creates a new instance but doesn't call any methods nor preform any assertions.
1 parent 342a346 commit a64dc79

File tree

5 files changed

+0
-50
lines changed

5 files changed

+0
-50
lines changed

Tests/RedisConsumerTest.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,6 @@ public function testShouldImplementConsumerInterface()
2222
$this->assertClassImplements(Consumer::class, RedisConsumer::class);
2323
}
2424

25-
/**
26-
* @doesNotPerformAssertions
27-
*/
28-
public function testCouldBeConstructedWithContextAndDestinationAndPreFetchCountAsArguments()
29-
{
30-
new RedisConsumer($this->createContextMock(), new RedisDestination('aQueue'));
31-
}
32-
3325
public function testShouldReturnDestinationSetInConstructorOnGetQueue()
3426
{
3527
$destination = new RedisDestination('aQueue');

Tests/RedisContextTest.php

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -25,24 +25,6 @@ public function testShouldImplementContextInterface()
2525
$this->assertClassImplements(Context::class, RedisContext::class);
2626
}
2727

28-
/**
29-
* @doesNotPerformAssertions
30-
*/
31-
public function testCouldBeConstructedWithRedisAsFirstArgument()
32-
{
33-
new RedisContext($this->createRedisMock(), 300);
34-
}
35-
36-
/**
37-
* @doesNotPerformAssertions
38-
*/
39-
public function testCouldBeConstructedWithRedisFactoryAsFirstArgument()
40-
{
41-
new RedisContext(function () {
42-
return $this->createRedisMock();
43-
}, 300);
44-
}
45-
4628
public function testThrowIfNeitherRedisNorFactoryGiven()
4729
{
4830
$this->expectException(\InvalidArgumentException::class);

Tests/RedisProducerTest.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,6 @@ public function testShouldImplementProducerInterface()
2525
$this->assertClassImplements(Producer::class, RedisProducer::class);
2626
}
2727

28-
/**
29-
* @doesNotPerformAssertions
30-
*/
31-
public function testCouldBeConstructedWithRedisAsFirstArgument()
32-
{
33-
new RedisProducer($this->createContextMock());
34-
}
35-
3628
public function testThrowIfDestinationNotRedisDestinationOnSend()
3729
{
3830
$producer = new RedisProducer($this->createContextMock());

Tests/RedisSubscriptionConsumerTest.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,6 @@ public function testShouldImplementSubscriptionConsumerInterface()
2222
$this->assertTrue($rc->implementsInterface(SubscriptionConsumer::class));
2323
}
2424

25-
/**
26-
* @doesNotPerformAssertions
27-
*/
28-
public function testCouldBeConstructedWithRedisContextAsFirstArgument()
29-
{
30-
new RedisSubscriptionConsumer($this->createRedisContextMock());
31-
}
32-
3325
public function testShouldAddConsumerAndCallbackToSubscribersPropertyOnSubscribe()
3426
{
3527
$subscriptionConsumer = new RedisSubscriptionConsumer($this->createRedisContextMock());

Tests/Spec/JsonSerializerTest.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,6 @@ public function testShouldImplementSerializerInterface()
2020
$this->assertClassImplements(Serializer::class, JsonSerializer::class);
2121
}
2222

23-
/**
24-
* @doesNotPerformAssertions
25-
*/
26-
public function testCouldBeConstructedWithoutAnyArguments()
27-
{
28-
new JsonSerializer();
29-
}
30-
3123
public function testShouldConvertMessageToJsonString()
3224
{
3325
$serializer = new JsonSerializer();

0 commit comments

Comments
 (0)