From ce5079ccfb8950bb101afce372e91db3135bb5de Mon Sep 17 00:00:00 2001 From: Nemo Date: Tue, 28 Feb 2017 16:15:28 +0530 Subject: [PATCH] Fix mock client strategy - The Strategy returned a invalid array earlier. >The return value is always an array with zero or more elements. >Each element is an array with two keys >['class' => string, 'condition' => mixed] - Added entry in CHANGELOG as well --- CHANGELOG.md | 2 ++ spec/Strategy/MockClientStrategySpec.php | 25 ++++++++++++++++++++++++ src/Strategy/MockClientStrategy.php | 2 +- 3 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 spec/Strategy/MockClientStrategySpec.php diff --git a/CHANGELOG.md b/CHANGELOG.md index 4d311a1..c72d6e9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,8 @@ ## Unreleased +- MockClientStategy class fixed + ## 1.2.0 - 2017-02-12 ### Added diff --git a/spec/Strategy/MockClientStrategySpec.php b/spec/Strategy/MockClientStrategySpec.php new file mode 100644 index 0000000..6a7e121 --- /dev/null +++ b/spec/Strategy/MockClientStrategySpec.php @@ -0,0 +1,25 @@ +getCandidates(HttpClient::class); + $candidates->shouldBeArray(); + $candidates->shouldHaveCount(1); + } +} diff --git a/src/Strategy/MockClientStrategy.php b/src/Strategy/MockClientStrategy.php index f200c1b..ea464cf 100644 --- a/src/Strategy/MockClientStrategy.php +++ b/src/Strategy/MockClientStrategy.php @@ -18,7 +18,7 @@ final class MockClientStrategy implements DiscoveryStrategy public static function getCandidates($type) { return ($type === HttpClient::class) - ? ['class' => Mock::class, 'condition' => Mock::class] + ? [['class' => Mock::class, 'condition' => Mock::class]] : []; } }