Skip to content

Commit 39bfab0

Browse files
authored
In PHP 7.2 the session_start() error messages have changed a bit (#359)
See PHP Bug 71038 for details https://bugs.php.net/bug.php?id=71038 Added PHP 7.2.0alpha2 to Travis CI matrix
1 parent 973f5ec commit 39bfab0

File tree

4 files changed

+37
-4
lines changed

4 files changed

+37
-4
lines changed

Diff for: .travis.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@ dist: trusty
33

44
language: php
55
php:
6-
- 7.0
6+
- 7.2.0alpha2
77
- 7.1
8+
- 7.0
89

910
matrix:
1011
fast_finish: true

Diff for: package.xml

+1
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ Fixes
113113
<file role='test' name='session_badconf_locktime.phpt'/>
114114
<file role='test' name='session_badconf_prefix.phpt'/>
115115
<file role='test' name='session_badconf_servers.phpt'/>
116+
<file role='test' name='session_badconf_servers-php72.phpt'/>
116117
<file role='test' name='session_basic.phpt'/>
117118
<file role='test' name='session_basic2.phpt'/>
118119
<file role='test' name='session_basic3.phpt'/>

Diff for: tests/session_badconf_servers-php72.phpt

+30
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
--TEST--
2+
Session bad configurations, invalid save path (server list)
3+
--SKIPIF--
4+
<?php
5+
include dirname(__FILE__) . "/skipif.inc";
6+
if (!Memcached::HAVE_SESSION) print "skip";
7+
if (PHP_VERSION_ID < 70200) print "skip";
8+
?>
9+
--INI--
10+
session.save_handler = memcached
11+
--FILE--
12+
<?php
13+
include dirname (__FILE__) . '/config.inc';
14+
ini_set ('session.save_path', MEMC_SERVER_HOST . ':' . MEMC_SERVER_PORT);
15+
16+
error_reporting(0);
17+
function handler($errno, $errstr) {
18+
echo "$errstr\n";
19+
}
20+
21+
set_error_handler('handler', E_ALL);
22+
23+
ini_set('memcached.sess_prefix', 'memc.sess.key.');
24+
ini_set('session.save_path', '');
25+
session_start();
26+
session_write_close();
27+
28+
--EXPECT--
29+
session_start(): failed to parse session.save_path
30+
session_start(): Failed to initialize storage module: memcached (path: )

Diff for: tests/session_badconf_servers.phpt

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
--TEST--
22
Session bad configurations, invalid save path (server list)
33
--SKIPIF--
4-
<?php
5-
include dirname(__FILE__) . "/skipif.inc";
4+
<?php
5+
include dirname(__FILE__) . "/skipif.inc";
66
if (!Memcached::HAVE_SESSION) print "skip";
7+
if (PHP_VERSION_ID > 70100) print "skip";
78
?>
89
--INI--
910
session.save_handler = memcached
@@ -24,5 +25,5 @@ ini_set('session.save_path', '');
2425
session_start();
2526
session_write_close();
2627

27-
--EXPECTF--
28+
--EXPECT--
2829
session_start(): failed to parse session.save_path

0 commit comments

Comments
 (0)