This will lead unexpected behavior if zval is an interned string

laruence · laruence · commit 5f28025c15c8 · 2017-05-23T11:43:19.000+08:00
diff --git a/php_memcached.c b/php_memcached.c
@@ -1019,7 +1019,6 @@ zend_string *s_zval_to_payload(php_memc_object_t *intern, zval *value, uint32_t
 		}
 			break;
 	}
-	zend_string_forget_hash_val(payload);
 
 	/* turn off compression for values below the threshold */
 	if (ZSTR_LEN(payload) == 0 || ZSTR_LEN(payload) < MEMC_G(compression_threshold)) {

Original file line number	Diff line number	Diff line change
`@@ -1019,7 +1019,6 @@ zend_string s_zval_to_payload(php_memc_object_t intern, zval *value, uint32_t`
`1019`	`1019`	`}`
`1020`	`1020`	`break;`
`1021`	`1021`	`}`
`1022`		`- zend_string_forget_hash_val(payload);`
`1023`	`1022`
`1024`	`1023`	`/* turn off compression for values below the threshold */`
`1025`	`1024`	`if (ZSTR_LEN(payload) == 0 \|\| ZSTR_LEN(payload) < MEMC_G(compression_threshold)) {`