Skip to content

memcached 3.1.3 does not compile on PHP 8.0 #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hackwar opened this issue Aug 20, 2019 · 0 comments · Fixed by #444
Closed

memcached 3.1.3 does not compile on PHP 8.0 #443

Hackwar opened this issue Aug 20, 2019 · 0 comments · Fixed by #444

Comments

@Hackwar
Copy link

Hackwar commented Aug 20, 2019

Hello,
we are running memcached in our CI system and have a daily PHP image for the newer versions and unfortunately the memcached extension doesn't compile anymore for PHP 8.0.

Our docker image file is here: https://github.com/joomla-projects/docker-images/tree/php8.0

And the error is

/usr/src/php/ext/memcached/php_memcached_session.c: In function 'ps_read_memcached':
/usr/src/php/ext/memcached/php_memcached_session.c:448:25: error: expected ')' before 'TSRMLS_CC'
   php_error_docref(NULL TSRMLS_CC, E_WARNING, "error getting session from memcached: %s", memcached_last_error_message(memc));
                         ^~~~~~~~~
/usr/src/php/ext/memcached/php_memcached_session.c:448:3: error: too few arguments to function 'php_error_docref'
   php_error_docref(NULL TSRMLS_CC, E_WARNING, "error getting session from memcached: %s", memcached_last_error_message(memc));
   ^~~~~~~~~~~~~~~~
In file included from /usr/src/php/ext/memcached/php_memcached.h:20,
                 from /usr/src/php/ext/memcached/php_memcached_session.c:17:
/usr/local/include/php/main/php.h:342:23: note: declared here
 PHPAPI ZEND_COLD void php_error_docref(const char *docref, int type, const char *format, ...)
                       ^~~~~~~~~~~~~~~~
/usr/src/php/ext/memcached/php_memcached_session.c: In function 'ps_write_memcached':
/usr/src/php/ext/memcached/php_memcached_session.c:478:26: error: expected ')' before 'TSRMLS_CC'
    php_error_docref(NULL TSRMLS_CC, E_WARNING, "error saving session to memcached: %s", memcached_last_error_message(memc));
                          ^~~~~~~~~
/usr/src/php/ext/memcached/php_memcached_session.c:478:4: error: too few arguments to function 'php_error_docref'
    php_error_docref(NULL TSRMLS_CC, E_WARNING, "error saving session to memcached: %s", memcached_last_error_message(memc));
    ^~~~~~~~~~~~~~~~
In file included from /usr/src/php/ext/memcached/php_memcached.h:20,
                 from /usr/src/php/ext/memcached/php_memcached_session.c:17:
/usr/local/include/php/main/php.h:342:23: note: declared here
 PHPAPI ZEND_COLD void php_error_docref(const char *docref, int type, const char *format, ...)
                       ^~~~~~~~~~~~~~~~
make: *** [Makefile:206: php_memcached_session.lo] Error 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant