From 70a9e130038b20c41148417d9cb08334a256a765 Mon Sep 17 00:00:00 2001 From: Timandes White Date: Tue, 19 Jul 2016 18:09:30 +0800 Subject: [PATCH 1/2] add parameter for method 'getStats' --- php_memcached.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/php_memcached.c b/php_memcached.c index ea3fe965..5ff6686b 100644 --- a/php_memcached.c +++ b/php_memcached.c @@ -2660,16 +2660,21 @@ memcached_return s_stat_execute_cb (php_memcached_instance_st instance, const ch PHP_METHOD(Memcached, getStats) { memcached_return status; + char *args = NULL; + zend_string *args_string = NULL; MEMC_METHOD_INIT_VARS; - if (zend_parse_parameters_none() == FAILURE) { + if (zend_parse_parameters(ZEND_NUM_ARGS(), "|S!", &args_string) == FAILURE) { return; } MEMC_METHOD_FETCH_OBJECT; + if (args_string) + args = ZSTR_VAL(args_string); + array_init(return_value); - status = memcached_stat_execute(intern->memc, NULL, s_stat_execute_cb, return_value); + status = memcached_stat_execute(intern->memc, args, s_stat_execute_cb, return_value); if (s_memc_status_handle_result_code(intern, status) == FAILURE) { zval_ptr_dtor(return_value); RETURN_FALSE; @@ -3983,6 +3988,7 @@ ZEND_BEGIN_ARG_INFO(arginfo_setBucket, 3) ZEND_END_ARG_INFO() ZEND_BEGIN_ARG_INFO(arginfo_getStats, 0) + ZEND_ARG_INFO(0, args) ZEND_END_ARG_INFO() ZEND_BEGIN_ARG_INFO(arginfo_getVersion, 0) From 83e9721be09c5197e901b639a9d3064f9be63fce Mon Sep 17 00:00:00 2001 From: Timandes White Date: Sun, 22 Jan 2017 09:57:41 +0800 Subject: [PATCH 2/2] Add optional parameter 'type' to 'memcached-api.php' doc file --- memcached-api.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/memcached-api.php b/memcached-api.php index e0e8f944..64b20b26 100644 --- a/memcached-api.php +++ b/memcached-api.php @@ -275,7 +275,7 @@ public function getLastDisconnectedServer( ) {} public function flush( $delay = 0 ) {} - public function getStats( ) {} + public function getStats( $type = null ) {} public function getVersion( ) {}