From f046e29c6d8cbcb0865f004b724463b4616eafa6 Mon Sep 17 00:00:00 2001 From: Aaron Stone Date: Fri, 7 Jul 2017 18:45:55 -0700 Subject: [PATCH 1/2] Add PHP 7.2 to Travis CI matrix --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 2581b516..d12cd3c9 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,8 +3,9 @@ dist: trusty language: php php: - - 7.0 + - 7.2.0alpha2 - 7.1 + - 7.0 matrix: fast_finish: true From 81e059e84d31e8eb0f4380401984e51fc23faea2 Mon Sep 17 00:00:00 2001 From: Aaron Stone Date: Tue, 11 Jul 2017 15:32:35 -0700 Subject: [PATCH 2/2] In PHP 7.2 the session_start() error messages have changed a bit See PHP Bug 71038 for details https://bugs.php.net/bug.php?id=71038 --- package.xml | 1 + tests/session_badconf_servers-php72.phpt | 30 ++++++++++++++++++++++++ tests/session_badconf_servers.phpt | 7 +++--- 3 files changed, 35 insertions(+), 3 deletions(-) create mode 100644 tests/session_badconf_servers-php72.phpt diff --git a/package.xml b/package.xml index 2cc8995b..5e1961f7 100644 --- a/package.xml +++ b/package.xml @@ -113,6 +113,7 @@ Fixes + diff --git a/tests/session_badconf_servers-php72.phpt b/tests/session_badconf_servers-php72.phpt new file mode 100644 index 00000000..92012369 --- /dev/null +++ b/tests/session_badconf_servers-php72.phpt @@ -0,0 +1,30 @@ +--TEST-- +Session bad configurations, invalid save path (server list) +--SKIPIF-- + +--INI-- +session.save_handler = memcached +--FILE-- + 70100) print "skip"; ?> --INI-- session.save_handler = memcached @@ -24,5 +25,5 @@ ini_set('session.save_path', ''); session_start(); session_write_close(); ---EXPECTF-- +--EXPECT-- session_start(): failed to parse session.save_path