Skip to content

Fix CI to work with PHP 7.4 and 8.x #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SOHELAHMED7 opened this issue Jun 5, 2024 · 2 comments · Fixed by #5
Closed

Fix CI to work with PHP 7.4 and 8.x #4

SOHELAHMED7 opened this issue Jun 5, 2024 · 2 comments · Fixed by #5
Assignees

Comments

@SOHELAHMED7
Copy link
Member

https://github.com/php-openapi/yii2-fractal/actions/runs/9379632474

@SOHELAHMED7
Copy link
Member Author

@cebe

I think we have to drop support for PHP 7.4 because in order to fix https://github.com/php-openapi/yii2-fractal/actions/runs/9379632474/job/25824965317 we need codeception/module-phpbrowser to at least 2.0.3

That requires codeception/lib-innerbrowser to 2.*

While achieving the above, Composer complains that codeception/module-yii2 requires codeception/lib-innerbrowser 1.* for PHP 7.4

There is no version of codeception/module-yii2 which supports PHP 7.4 and is dependent on codeception/lib-innerbrowser 1.*

v1.1.5 of codeception/module-yii2 requires codeception/lib-innerbrowser 1.*

v1.1.6 of codeception/module-yii2 requires codeception/lib-innerbrowser 2.* and PHP ^8

What are your thoughts?

@cebe
Copy link
Member

cebe commented Jun 6, 2024

I'm okay with going to >=8.0 only for this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants