Skip to content

Commit 36ab8b4

Browse files
jrfnlgrogy
authored andcommitted
Fix PHAR not being compatible with PHP < 7.0 / Composer 2.3
During builds, the PHAR file is generated and uploaded as an artefact to be used during the test job. Along the same lines, the PHAR file is generated via a GH Actions workflow when a new version has been tagged and uploaded to the "Release". Composer 2.3 has been released last week, which has a minimum PHP version of PHP 7.2 and the autoload files generated with Composer 2.3 are no longer compatible with PHP < 7.0. Composer 2.2 (with a minimum PHP version of PHP 5.3) is now a LTS (long term service) release and will receive essential bug fixes. The `setup-php` action runner will automatically install the appropriate version of Composer depending on the PHP version requested - Composer 2.2 for PHP < 7.2 and Composer 2.3+ for PHP 7.2+. For the PHAR file, which is being generated on PHP 8.0 in the workflows, this means that Composer 2.3 is being installed and used to generate the PHAR file, which means that the autoload files generated with Composer 2.3 will be included, which makes the PHAR incompatible with PHP < 7.0. To fix this, I'm adding a `tools` key to the `setup-php` action runner for the PHAR generation workflow which explicitly demands Composer 2.2.x, ensuring that the autoload files which will be included in the PHAR file will be compatible with PHP < 7.0. Refs: * https://blog.packagist.com/composer-2-3/ * https://github.com/composer/composer/releases
1 parent 8f8a9cd commit 36ab8b4

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

Diff for: .github/workflows/release.yml

+2
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ jobs:
3232
extensions: exif, phar, openssl
3333
coverage: none
3434
ini-values: phar.readonly=Off, error_reporting=-1, display_errors=On, zend.assertions=1
35+
# Autoload files generated with Composer 2.3 are not compatible with PHP < 7.0.
36+
tools: composer:2.2
3537

3638
- name: Install Composer dependencies
3739
uses: ramsey/composer-install@v2

Diff for: .github/workflows/test.yml

+2
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ jobs:
5555
extensions: exif, phar, openssl
5656
coverage: none
5757
ini-values: phar.readonly=Off, error_reporting=-1, display_errors=On, zend.assertions=1
58+
# Autoload files generated with Composer 2.3 are not compatible with PHP < 7.0.
59+
tools: composer:2.2
5860

5961
- name: Install Composer dependencies
6062
uses: ramsey/composer-install@v2

0 commit comments

Comments
 (0)