Fixed files skipping based on version_compare() in Windows

kukulich · kukulich · commit 50e939edf816 · 2017-02-15T15:54:57.000+01:00
diff --git a/bin/skip-linting.php b/bin/skip-linting.php
@@ -10,11 +10,9 @@
         $firstLine = fgets($f);
         @fclose($f);
 
-        if (!preg_match('~<?php\\s*\\/\\/\s*lint\s*([^\d\s]+)\s*([^\s]+)\s*~i', $firstLine, $m)) {
-            $skip = false;
+        if (preg_match('~<?php\\s*\\/\\/\s*lint\s*([^\d\s]+)\s*([^\s]+)\s*~i', $firstLine, $m)) {
+            $skip = version_compare(PHP_VERSION, $m[2], $m[1]) === false;
         }
-
-        $skip = isset($m[2]) && !version_compare(PHP_VERSION, $m[2], $m[1]);
     }
 
     echo $file . ';' . ($skip ? '1' : '0') . PHP_EOL;

Original file line number	Diff line number	Diff line change
`@@ -10,11 +10,9 @@`
`10`	`10`	`$firstLine = fgets($f);`
`11`	`11`	`@fclose($f);`
`12`	`12`
`13`		`- if (!preg_match('~<?php\\s\\/\\/\slint\s([^\d\s]+)\s([^\s]+)\s*~i', $firstLine, $m)) {`
`14`		`- $skip = false;`
	`13`	`+ if (preg_match('~<?php\\s\\/\\/\slint\s([^\d\s]+)\s([^\s]+)\s*~i', $firstLine, $m)) {`
	`14`	`+ $skip = version_compare(PHP_VERSION, $m[2], $m[1]) === false;`
`15`	`15`	`}`
`16`		`-`
`17`		`- $skip = isset($m[2]) && !version_compare(PHP_VERSION, $m[2], $m[1]);`
`18`	`16`	`}`
`19`	`17`
`20`	`18`	`echo $file . ';' . ($skip ? '1' : '0') . PHP_EOL;`