Skip to content

Commit 5ca9c0c

Browse files
committed
GH Actions: allow for testing on PHP 5.3
In anticipation of PR 51 being merged, I'm already adding an extra step to the `test` job. PHP_CodeSniffer has a minimum PHP requirement of PHP 5.4, which would block the `composer install` on PHP 5.3. By removing that `dev` dependency ahead of the `composer install`, the test workflow can also run on PHP 5.3.
1 parent 2c1511b commit 5ca9c0c

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

Diff for: .github/workflows/test.yml

+5
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,11 @@ jobs:
105105
php-version: ${{ matrix.php }}
106106
coverage: none
107107

108+
# Remove PHPCS as it has a minimum PHP requirements of PHP 5.4 and would block install on PHP 5.3.
109+
- name: 'Composer: remove PHPCS'
110+
if: ${{ matrix.php < 5.4 }}
111+
run: composer remove --dev squizlabs/php_codesniffer --no-update
112+
108113
- name: Install Composer dependencies
109114
uses: ramsey/composer-install@v1
110115

0 commit comments

Comments
 (0)