SolrUtils::escapeQueryChars returns null if an empty string is passed in #83
Assignees
Comments
bix0r
added a commit
to bix0r/pecl-search_engine-solr
that referenced
this issue
Mar 31, 2025
Fixes php#83 There is no reason for returning null given an empty string. Plus, the methods don't actually "say" they return null, ever. Also, escapeQueryChars() actually never returns false. That will be fixed in documentation.
bix0r
added a commit
that referenced
this issue
Apr 21, 2025
Fix bad return or empty string arguments in SolrUtils
bix0r
added a commit
to bix0r/doc-en
that referenced
this issue
Apr 21, 2025
As noted in php/pecl-search_engine-solr#83, and fixed in php/pecl-search_engine-solr#84 the method actually never returns anything else then a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following code:
Resulted in this output:
But I expected this output instead:
The documentation states that the function will return the escaped string or false on failure. I don't think escaping an empty string should result in failure, but even if this was intended, the result should be false, not null.
Additionally, I would be like to know under what circumstances escaping even can fail. Maybe the documentation could give an example?
The text was updated successfully, but these errors were encountered: