Skip to content

Commit 471e94c

Browse files
orlitzkyarnaud-lb
authored andcommitted
ext/gettext/config.m4: symlink en_US.UTF-8 test bits to en_US for musl
The gettext() family of functions under musl does not support codeset suffixes like ".UTF-8", because the only codeset it understands is UTF-8. (Yes, it is annoying that it doesn't support the suffix for the codeset that it does understand; no, I am not in charge.) Thanks to this, we have six failing tests on musl, * FAIL Gettext basic test with en_US locale that should be on nearly every system [ext/gettext/tests/gettext_basic-enus.phpt] * FAIL Test if bindtextdomain() returns string id if no directory path is set( if directory path is 'null') [ext/gettext/tests/gettext_bindtextdomain-cwd.phpt] * FAIL Test dcgettext() functionality [ext/gettext/tests/gettext_dcgettext.phpt] * FAIL Test dgettext() functionality [ext/gettext/tests/gettext_dgettext.phpt] * FAIL Test if dngettext() returns the correct translations (optionally plural). [ext/gettext/tests/gettext_dngettext-plural.phpt] * FAIL Test ngettext() functionality [ext/gettext/tests/gettext_ngettext.phpt] These are all fixed by symlinking the en_US.UTF-8 message data to en_US, where musl is able to find it. This does not make the situation any better for developers (who don't know what libc their users will be running), but that problem is inhereted from C and is not the fault of the gettext extension. This partially addresses GH #13696
1 parent bfb0e36 commit 471e94c

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,9 @@ php
177177
/ext/*/configure.ac
178178
/ext/*/run-tests.php
179179

180+
# Generated by ./configure if libc might be musl
181+
/ext/gettext/tests/locale/en_US
182+
180183
# ------------------------------------------------------------------------------
181184
# Generated by Windows build system
182185
# ------------------------------------------------------------------------------

ext/gettext/config.m4

+11
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,17 @@ if test "$PHP_GETTEXT" != "no"; then
2525
AC_CHECK_LIB(c, bindtextdomain, [
2626
GETTEXT_LIBS=
2727
GETTEXT_CHECK_IN_LIB=c
28+
29+
dnl If libintl.h is provided by libc, it's possible that libc is musl.
30+
dnl The gettext family of functions under musl ignores the codeset
31+
dnl suffix on directories like "en_US.UTF-8"; instead they look only
32+
dnl in "en_US". To accomodate that, we symlink some test data from one
33+
dnl to the other.
34+
AC_MSG_NOTICE([symlinking en_US.UTF-8 messages to en_US in case you are on musl])
35+
_linkdest="${srcdir%/}"/ext/gettext/tests/locale/en_US
36+
AS_IF([test ! -e "${_linkdest}"],[
37+
ln -s en_US.UTF-8 "${_linkdest}"
38+
])
2839
],[
2940
AC_MSG_ERROR(Unable to find required gettext library)
3041
])

0 commit comments

Comments
 (0)