Skip to content

Commit 53c2706

Browse files
committed
Change default setting for zend.exception_ignore_args
The default setting for zend.exception_ignore_args (On) should be the safest setting rather than the setting more convenient to developers (Off).
1 parent 13e0fb9 commit 53c2706

6 files changed

+8
-7
lines changed

Zend/tests/backtrace/fatal_error_backtraces_001.phpt

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
2-
Fatal error backtrace
2+
Fatal error backtrace w/o zend.exception_ignore_args
33
--INI--
44
fatal_error_backtraces=On
5+
zend.exception_ignore_args=Off
56
--FILE--
67
<?php
78

Zend/tests/backtrace/fatal_error_backtraces_002.phpt

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
2-
Fatal error backtrace w/ sensitive parameters
2+
Fatal error backtrace w/ sensitive parameters w/o zend.exception_ignore_args
33
--INI--
44
fatal_error_backtraces=On
5+
zend.exception_ignore_args=Off
56
--FILE--
67
<?php
78

Zend/tests/backtrace/fatal_error_backtraces_003.phpt

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
--TEST--
2-
Fatal error backtrace w/ zend.exception_ignore_args
2+
Fatal error backtrace
33
--INI--
44
fatal_error_backtraces=On
5-
zend.exception_ignore_args=On
65
--FILE--
76
<?php
87

Zend/zend.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ ZEND_INI_BEGIN()
269269
#ifdef ZEND_SIGNALS
270270
STD_ZEND_INI_BOOLEAN("zend.signal_check", SIGNAL_CHECK_DEFAULT, ZEND_INI_SYSTEM, OnUpdateBool, check, zend_signal_globals_t, zend_signal_globals)
271271
#endif
272-
STD_ZEND_INI_BOOLEAN("zend.exception_ignore_args", "0", ZEND_INI_ALL, OnUpdateBool, exception_ignore_args, zend_executor_globals, executor_globals)
272+
STD_ZEND_INI_BOOLEAN("zend.exception_ignore_args", "1", ZEND_INI_ALL, OnUpdateBool, exception_ignore_args, zend_executor_globals, executor_globals)
273273
STD_ZEND_INI_ENTRY("zend.exception_string_param_max_len", "15", ZEND_INI_ALL, OnSetExceptionStringParamMaxLen, exception_string_param_max_len, zend_executor_globals, executor_globals)
274274
STD_ZEND_INI_ENTRY("fiber.stack_size", NULL, ZEND_INI_ALL, OnUpdateFiberStackSize, fiber_stack_size, zend_executor_globals, executor_globals)
275275
#ifdef ZEND_CHECK_STACK_LIMIT

php.ini-development

+1-1
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@
160160
; Production Value: -1
161161

162162
; zend.exception_ignore_args
163-
; Default Value: Off
163+
; Default Value: On
164164
; Development Value: Off
165165
; Production Value: On
166166

php.ini-production

+1-1
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@
160160
; Production Value: -1
161161

162162
; zend.exception_ignore_args
163-
; Default Value: Off
163+
; Default Value: On
164164
; Development Value: Off
165165
; Production Value: On
166166

0 commit comments

Comments
 (0)