Skip to content

Commit 5bcbe8a

Browse files
committed
Fix minimal Windows version
As of PHP 8.3.0, Windows 8/Server 2012 are the minimum requirement. However, PR #9104 only updated `_WIN32_WINNT`, but not `WINVER`[1], `NTDDI_VERSION`[2] nor the manifest[3]. [1] <https://learn.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers> [2] <https://learn.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers> [3] <https://learn.microsoft.com/en-us/windows/win32/sbscs/application-manifests> Closes GH-15975.
1 parent ffc355c commit 5bcbe8a

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

Diff for: NEWS

+3
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ PHP NEWS
2727
- TSRM:
2828
. Prevent closing of unrelated handles. (cmb)
2929

30+
- Windows:
31+
. Fixed minimal Windows version. (cmb)
32+
3033
12 Sep 2024, PHP 8.3.12
3134

3235
- Core:

Diff for: win32/build/config.w32.h.in

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#undef _WIN32_WINNT
77
#undef NTDDI_VERSION
88
#define _WIN32_WINNT 0x0602
9-
#define NTDDI_VERSION 0x06010000
9+
#define NTDDI_VERSION 0x06020000
1010

1111
/* Default PHP / PEAR directories */
1212
#define PHP_CONFIG_FILE_PATH ""

Diff for: win32/build/confutils.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ var PHP_MAKEFILE_FRAGMENTS = PHP_SRC_DIR + "\\Makefile.fragments.w32";
5050

5151
/* Care also about NTDDI_VERSION and _WIN32_WINNT in config.w32.h.in
5252
and manifest. */
53-
var WINVER = "0x0601"; /* 7/2008r2 */
53+
var WINVER = "0x0602"; /* 8/2012 */
5454

5555
// There's a minimum requirement for bison.
5656
var MINBISON = "3.0.0";

Diff for: win32/build/default.manifest

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
</trustInfo>
1010
<compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
1111
<application>
12-
<!-- Windows 7 -->
13-
<supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
1412
<!-- Windows 8 -->
1513
<supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
1614
<!-- Windows 8.1 -->

0 commit comments

Comments
 (0)