Skip to content

Commit bb4f809

Browse files
committed
Change default setting for zend.exception_ignore_args
The default setting for zend.exception_ignore_args (On) should be the safest setting rather than the setting more convenient to developers (Off).
1 parent 13e0fb9 commit bb4f809

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

UPGRADING

+3
Original file line numberDiff line numberDiff line change
@@ -407,6 +407,9 @@ PHP 8.5 UPGRADE NOTES
407407
. The high resolution timer (`hrtime()`) on macOS now uses the recommended
408408
`clock_gettime_nsec_np(CLOCK_UPTIME_RAW)` API instead of
409409
`mach_absolute_time()`.
410+
. Exceptions now exclude arguments passed in the stack trace. If the old
411+
behaviour is disabled, then set `zend.exception_ignore_args=0` in INI
412+
settings.
410413

411414
- CLI/CGI:
412415
. The `-z` or `--zend-extension` option has been removed as it was

Zend/zend.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ ZEND_INI_BEGIN()
269269
#ifdef ZEND_SIGNALS
270270
STD_ZEND_INI_BOOLEAN("zend.signal_check", SIGNAL_CHECK_DEFAULT, ZEND_INI_SYSTEM, OnUpdateBool, check, zend_signal_globals_t, zend_signal_globals)
271271
#endif
272-
STD_ZEND_INI_BOOLEAN("zend.exception_ignore_args", "0", ZEND_INI_ALL, OnUpdateBool, exception_ignore_args, zend_executor_globals, executor_globals)
272+
STD_ZEND_INI_BOOLEAN("zend.exception_ignore_args", "1", ZEND_INI_ALL, OnUpdateBool, exception_ignore_args, zend_executor_globals, executor_globals)
273273
STD_ZEND_INI_ENTRY("zend.exception_string_param_max_len", "15", ZEND_INI_ALL, OnSetExceptionStringParamMaxLen, exception_string_param_max_len, zend_executor_globals, executor_globals)
274274
STD_ZEND_INI_ENTRY("fiber.stack_size", NULL, ZEND_INI_ALL, OnUpdateFiberStackSize, fiber_stack_size, zend_executor_globals, executor_globals)
275275
#ifdef ZEND_CHECK_STACK_LIMIT

ext/soap/tests/bugs/bug62900.phpt

+4-4
Original file line numberDiff line numberDiff line change
@@ -72,24 +72,24 @@ foreach ($combinations as list($wsdl, $xsd)) {
7272
--EXPECTF--
7373
Fatal error: Uncaught SoapFault exception: [WSDL] SOAP-ERROR: Parsing Schema: can't import schema from '%sbug62900.xsd', unexpected 'targetNamespace'='http://www.w3.org/XML/1998/namespacex', expected 'http://www.w3.org/XML/1998/namespace' in %s:%d
7474
Stack trace:
75-
#0 %s(%d): SoapClient->__construct(%s)
75+
#0 %s(%d): SoapClient->__construct()
7676
#1 {main}
7777
thrown in %s on line %d
7878

7979
Fatal error: Uncaught SoapFault exception: [WSDL] SOAP-ERROR: Parsing Schema: can't import schema from '%sbug62900.xsd', missing 'targetNamespace', expected 'http://www.w3.org/XML/1998/namespace' in %s:%d
8080
Stack trace:
81-
#0 %s(%d): SoapClient->__construct(%s)
81+
#0 %s(%d): SoapClient->__construct()
8282
#1 {main}
8383
thrown in %s on line %d
8484

8585
Fatal error: Uncaught SoapFault exception: [WSDL] SOAP-ERROR: Parsing Schema: can't import schema from '%sbug62900.xsd', unexpected 'targetNamespace'='http://www.w3.org/XML/1998/namespacex', expected no 'targetNamespace' in %s:%d
8686
Stack trace:
87-
#0 %s(%d): SoapClient->__construct(%s)
87+
#0 %s(%d): SoapClient->__construct()
8888
#1 {main}
8989
thrown in %s on line %d
9090

9191
Fatal error: Uncaught SoapFault exception: [WSDL] SOAP-ERROR: Parsing WSDL: Couldn't bind to service in %s:%d
9292
Stack trace:
93-
#0 %s(%d): SoapClient->__construct(%s)
93+
#0 %s(%d): SoapClient->__construct()
9494
#1 {main}
9595
thrown in %s on line %d

php.ini-development

+1-1
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@
160160
; Production Value: -1
161161

162162
; zend.exception_ignore_args
163-
; Default Value: Off
163+
; Default Value: On
164164
; Development Value: Off
165165
; Production Value: On
166166

php.ini-production

+1-1
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@
160160
; Production Value: -1
161161

162162
; zend.exception_ignore_args
163-
; Default Value: Off
163+
; Default Value: On
164164
; Development Value: Off
165165
; Production Value: On
166166

0 commit comments

Comments
 (0)