Skip to content

Commit 3c94cc7

Browse files
authored
Merge pull request #7 from php-win-ext/fix_sdk_starter_call
use sdk-starter.bat instead of specific file
2 parents eb2adac + 5884c9f commit 3c94cc7

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Diff for: extension/BuildPhpExtension/private/Add-Extension.ps1

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Function Add-Extension {
4242
$bat_content += "nmake /nologo 2>&1"
4343
$bat_content += "exit %errorlevel%"
4444
Set-Content -Encoding "ASCII" -Path $Extension-task.bat -Value $bat_content
45-
$builder = "$currentDirectory\php-sdk\phpsdk-$($Config.vs_version)-$($Config.Arch).bat"
45+
$builder = "$currentDirectory\php-sdk\phpsdk-starter.bat"
4646
$task = (Get-Item -Path "." -Verbose).FullName + "\$Extension-task.bat"
4747
$suffix = "php_" + (@(
4848
$Config.name,
@@ -52,7 +52,7 @@ Function Add-Extension {
5252
$Config.vs_version,
5353
$Config.arch
5454
) -join "-")
55-
& $builder -t $task | Tee-Object -FilePath "build-$suffix.txt"
55+
& $builder -c $Config.vs_version -a $Config.Arch -t $task | Tee-Object -FilePath "build-$suffix.txt"
5656
$includePath = "$currentDirectory\php-dev\include"
5757
New-Item -Path $includePath\ext -Name $Extension -ItemType "directory" | Out-Null
5858
Get-ChildItem -Path (Get-Location).Path -Recurse -Include '*.h', '*.c' | Copy-Item -Destination "$includePath\ext\$Extension"

Diff for: extension/BuildPhpExtension/private/Invoke-Build.ps1

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Function Invoke-Build {
2424
$bat_content += "exit %errorlevel%"
2525
Set-Content -Encoding "ASCII" -Path task.bat -Value $bat_content
2626

27-
$builder = "php-sdk\phpsdk-$($Config.vs_version)-$($Config.Arch).bat"
27+
$builder = "php-sdk\phpsdk-starter.bat"
2828
$task = (Get-Item -Path "." -Verbose).FullName + '\task.bat'
2929
$ref = $Config.ref
3030
if($env:ARTIFACT_NAMING_SCHEME -eq 'pecl') {
@@ -38,7 +38,7 @@ Function Invoke-Build {
3838
$Config.vs_version,
3939
$Config.arch
4040
) -join "-")
41-
& $builder -s $Config.vs_toolset -t $task | Tee-Object -FilePath "build-$suffix.txt"
41+
& $builder -c $Config.vs_version -a $Config.Arch -s $Config.vs_toolset -t $task | Tee-Object -FilePath "build-$suffix.txt"
4242
Set-GAGroup end
4343
Add-BuildLog tick $Config.name "Extension $($Config.name) built successfully"
4444
} catch {

Diff for: php/BuildPhp/public/Invoke-PhpBuild.ps1

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function Invoke-PhpBuild {
5353

5454
$task = "$PSScriptRoot\..\runner\task-$Ts.bat"
5555

56-
& "$buildDirectory\php-sdk\phpsdk-$VsVersion-$Arch.bat" -t $task
56+
& "$buildDirectory\php-sdk\phpsdk-starter.bat" -c $VsVersion -a $Arch -t $task
5757
if (-not $?) {
5858
throw "build failed with errorlevel $LastExitCode"
5959
}

0 commit comments

Comments
 (0)