Improve vs runtime check

Author: shivammathur

extension/BuildPhpExtension/config/vs.json

@@ -13,19 +13,23 @@
   "vs" : {
     "vc14": {
       "major": 14,
-      "minor": 9
+      "minorMin": 0,
+      "minorMax": 9
     },
     "vc15": {
       "major": 14,
-      "minor": 19
+      "minorMin": 10,
+      "minorMax": 19
     },
     "vs16": {
       "major": 14,
-      "minor": 29
+      "minorMin": 20,
+      "minorMax": 29
     },
     "vs17": {
       "major": 14,
-      "minor": 42
+      "minorMin": 30,
+      "minorMax": null
     }
   }
 }

extension/BuildPhpExtension/private/Get-VsVersion.ps1

@@ -30,9 +30,8 @@ function Get-VsVersion {
         foreach ($toolset in (Get-ChildItem $MSVCDirectory)) {
             $toolsetMajorVersion, $toolsetMinorVersion = $toolset.Name.split(".")[0,1]
             $requiredVs = $VsConfig.vs.$VsVersion
-            if ($requiredVs.major -eq $toolsetMajorVersion -and ($null -eq $requiredVs.minor -or $toolsetMinorVersion -le $requiredVs.minor)) {
-                if($null -eq $minor -or $toolsetMinorVersion -gt $minor)
-                {
+            if ($requiredVs.major -eq $toolsetMajorVersion -and ($toolsetMinorVersion -ge $requiredVs.minorMin -and ($null -eq $requiredVs.minorMax -or $toolsetMinorVersion -le $requiredVs.minorMax))) {
+                if($null -eq $minor -or $toolsetMinorVersion -gt $minor) {
                     $selectedToolset = $toolset.Name.Trim()
                     $minor = $toolsetMinorVersion
                 }