No useless dive into EM::createQueryBuilder

janedbal · janedbal · commit 2d0ceb341175 · 2023-12-04T12:08:21.000+01:00
diff --git a/src/Type/Doctrine/QueryBuilder/ReturnQueryBuilderExpressionTypeResolverExtension.php b/src/Type/Doctrine/QueryBuilder/ReturnQueryBuilderExpressionTypeResolverExtension.php
@@ -2,6 +2,7 @@
 
 namespace PHPStan\Type\Doctrine\QueryBuilder;
 
+use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\EntityRepository;
 use Doctrine\ORM\QueryBuilder;
 use PhpParser\Node\Expr;
@@ -91,6 +92,9 @@ private function getMethodReflection(CallLike $call, Scope $scope): ?MethodRefle
 			if ($callerClassReflection->is(EntityRepository::class) && $methodName === 'createQueryBuilder') {
 				return null; // covered by EntityRepositoryCreateQueryBuilderDynamicReturnTypeExtension
 			}
+			if ($callerClassReflection->is(EntityManagerInterface::class) && $methodName === 'createQueryBuilder') {
+				return null; // no need to dive there
+			}
 		}
 
 		return $scope->getMethodReflection($callerType, $methodName);

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace PHPStan\Type\Doctrine\QueryBuilder;`
`4`	`4`
	`5`	`+use Doctrine\ORM\EntityManagerInterface;`
`5`	`6`	`use Doctrine\ORM\EntityRepository;`
`6`	`7`	`use Doctrine\ORM\QueryBuilder;`
`7`	`8`	`use PhpParser\Node\Expr;`
`@@ -91,6 +92,9 @@ private function getMethodReflection(CallLike $call, Scope $scope): ?MethodRefle`
`91`	`92`	`if ($callerClassReflection->is(EntityRepository::class) && $methodName === 'createQueryBuilder') {`
`92`	`93`	`return null; // covered by EntityRepositoryCreateQueryBuilderDynamicReturnTypeExtension`
`93`	`94`	`}`
	`95`	`+ if ($callerClassReflection->is(EntityManagerInterface::class) && $methodName === 'createQueryBuilder') {`
	`96`	`+ return null; // no need to dive there`
	`97`	`+ }`
`94`	`98`	`}`
`95`	`99`
`96`	`100`	`return $scope->getMethodReflection($callerType, $methodName);`