Poc

Author: VincentLanglet

Diff for: .github/workflows/test-platforms.yml

@@ -0,0 +1,58 @@
+# https://help.github.com/en/categories/automating-your-workflow-with-github-actions
+
+name: "Test on platforms"
+
+on:
+  pull_request:
+  push:
+    branches:
+      - "1.3.x"
+
+jobs:
+  test-mysql:
+    name: "Tests mysql"
+    runs-on: "ubuntu-latest"
+
+    env:
+      DATABASE_URL: mysql://[email protected]:3306/phpstan_doctrine
+
+    services:
+      mysql:
+        image: mysql:${{ matrix.mysql-version }}
+        options: >-
+          --health-cmd "mysqladmin ping --silent"
+          --name=mysqlcontainer
+          -e MYSQL_ALLOW_EMPTY_PASSWORD=yes
+          -e MYSQL_DATABASE=phpstan_doctrine
+        ports:
+          - 3306:3306
+
+    strategy:
+      fail-fast: false
+      matrix:
+        php-version:
+          - "8.2"
+        mysql-version:
+          - '5.7'
+          - '8.0'
+
+    steps:
+      - name: "Checkout"
+        uses: actions/checkout@v3
+
+      - name: "Install PHP"
+        uses: "shivammathur/setup-php@v2"
+        with:
+          coverage: "none"
+          php-version: "${{ matrix.php-version }}"
+          ini-file: development
+          extensions: "mongodb"
+
+      - name: "Install dependencies"
+        run: "composer update --no-interaction --no-progress"
+
+      - name: Change mysql sql_mode
+        run: "docker exec mysqlcontainer mysql -u root -e \"SET GLOBAL sql_mode = '';\""
+
+      - name: "Tests"
+        run: "vendor/bin/phpunit --group=mysql"

Diff for: Makefile

@@ -3,7 +3,7 @@ check: lint cs tests phpstan
 
 .PHONY: tests
 tests:
-	php vendor/bin/phpunit
+	php vendor/bin/phpunit --exclude-group=platform
 
 .PHONY: lint
 lint:

Diff for: tests/Type/Doctrine/Query/MysqlQueryResultTypeWalkerTest.php

@@ -0,0 +1,17 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Doctrine\Query;
+
+/**
+ * @group platform
+ * @group mysql
+ */
+class MysqlQueryResultTypeWalkerTest extends PDOQueryResultTypeWalkerTest
+{
+
+	protected static function getEntityManagerPath(): string
+	{
+		return __DIR__ . '/../data/QueryResult/entity-manager-mysql.php';
+	}
+
+}

Diff for: tests/Type/Doctrine/Query/PDOQueryResultTypeWalkerTest.php

@@ -15,7 +15,6 @@
 use PHPStan\Type\NullType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\StringType;
-use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
 use QueryResult\Entities\Many;
 use QueryResult\Entities\ManyId;
@@ -29,17 +28,14 @@
 use function strpos;
 use const PHP_VERSION_ID;
 
-final class PDOQueryResultTypeWalkerTest extends QueryResultTypeWalkerTestCase
+class PDOQueryResultTypeWalkerTest extends QueryResultTypeWalkerTestCase
 {
 
 	protected static function getEntityManagerPath(): string
 	{
 		return __DIR__ . '/../data/QueryResult/entity-manager.php';
 	}
 
-	/**
-	 * @return iterable<string,array{Type,string,2?:string|null}>
-	 */
 	public function getTestData(): iterable
 	{
 		$ormVersion = InstalledVersions::getVersion('doctrine/orm');

Diff for: tests/Type/Doctrine/Query/QueryResultTypeWalkerTestCase.php

@@ -48,8 +48,9 @@
 
 abstract class QueryResultTypeWalkerTestCase extends PHPStanTestCase
 {
+
 	/** @var EntityManagerInterface */
-	private static $em;
+	protected static $em;
 
 	/** @var DescriptorRegistry */
 	private $descriptorRegistry;
@@ -182,7 +183,9 @@ public function setUp(): void
 		$this->descriptorRegistry = self::getContainer()->getByType(DescriptorRegistry::class);
 	}
 
-	/** @dataProvider getTestData */
+	/**
+	 * @dataProvider getTestData
+	 */
 	public function test(Type $expectedType, string $dql, ?string $expectedExceptionMessage = null, ?string $expectedDeprecationMessage = null): void
 	{
 		$em = self::$em;

Diff for: tests/Type/Doctrine/data/QueryResult/entity-manager-mysql.php

@@ -0,0 +1,40 @@
+<?php declare(strict_types = 1);
+
+use Cache\Adapter\PHPArray\ArrayCachePool;
+use Doctrine\Common\Annotations\AnnotationReader;
+use Doctrine\DBAL\DriverManager;
+use Doctrine\ORM\Configuration;
+use Doctrine\ORM\EntityManager;
+use Doctrine\ORM\Mapping\Column;
+use Doctrine\ORM\Mapping\Driver\AnnotationDriver;
+use Doctrine\ORM\Mapping\Driver\AttributeDriver;
+use Doctrine\Persistence\Mapping\Driver\MappingDriverChain;
+
+$config = new Configuration();
+$config->setProxyDir(__DIR__);
+$config->setProxyNamespace('PHPstan\Doctrine\OrmProxies');
+$config->setMetadataCache(new ArrayCachePool());
+
+$metadataDriver = new MappingDriverChain();
+
+$metadataDriver->addDriver(new AnnotationDriver(
+	new AnnotationReader(),
+	[__DIR__ . '/Entities']
+), 'QueryResult\Entities\\');
+
+if (property_exists(Column::class, 'enumType') && PHP_VERSION_ID >= 80100) {
+	$metadataDriver->addDriver(new AnnotationDriver(
+		new AnnotationReader(),
+		[__DIR__ . '/EntitiesEnum']
+	), 'QueryResult\EntitiesEnum\\');
+}
+
+$config->setMetadataDriverImpl($metadataDriver);
+
+return new EntityManager(
+	DriverManager::getConnection([
+		'driver' => 'mysql',
+		'url' => 'mysql://[email protected]:3306/phpstan_doctrine',
+	]),
+	$config
+);