RegularExpressionPatternRule: support extended Nette\Utils\Strings

Author: janedbal

Diff for: src/Rule/Nette/RegularExpressionPatternRule.php

@@ -9,6 +9,7 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\Type\ObjectType;
 use function in_array;
 use function sprintf;
 use function strtolower;
@@ -51,8 +52,8 @@ private function extractPatterns(StaticCall $staticCall, Scope $scope): array
 		if (!$staticCall->class instanceof Node\Name || !$staticCall->name instanceof Node\Identifier) {
 			return [];
 		}
-		$className = $scope->resolveName($staticCall->class);
-		if ($className !== Strings::class) {
+		$caller = $scope->resolveTypeByName($staticCall->class);
+		if (!(new ObjectType(Strings::class))->isSuperTypeOf($caller)->yes()) {
 			return [];
 		}
 		$methodName = strtolower((string) $staticCall->name);

Diff for: tests/Rule/Nette/RegularExpressionPatternRuleTest.php

@@ -71,6 +71,10 @@ public function testValidRegexPatternAfter73(): void
 					'Regex pattern is invalid: Compilation failed: missing closing parenthesis at offset 1 in pattern: ~(~',
 					26,
 				],
+				[
+					sprintf('Regex pattern is invalid: Delimiter must not be %s in pattern: nok', $messagePart),
+					36,
+				],
 			],
 		);
 	}

Diff for: tests/Rule/Nette/data/valid-regex-pattern.php

@@ -31,3 +31,6 @@
 		'~(~' => function () {},
 	]
 );
+
+class MyStrings extends \Nette\Utils\Strings {}
+MyStrings::replace('', 'nok', '');